Build iOS unittest target in unopt builds (flutter#44301)

Chris Yang · web-flow · commit 9c17c35d1bce · 2023-08-03T20:33:04.000Z
build ios unittest target in unopt builds. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
diff --git a/shell/platform/darwin/ios/BUILD.gn b/shell/platform/darwin/ios/BUILD.gn
@@ -264,7 +264,6 @@ source_set("ios_test_flutter_mrc") {
 }
 
 shared_library("ios_test_flutter") {
-  testonly = true
   visibility = [ ":*" ]
   cflags = [
     "-fvisibility=default",
@@ -304,7 +303,6 @@ shared_library("ios_test_flutter") {
     "framework/Source/connection_collection_test.mm",
   ]
   deps = [
-    ":flutter_framework",
     ":flutter_framework_source",
     ":flutter_framework_source_arc",
     ":ios_gpu_configuration",
@@ -467,4 +465,8 @@ action("flutter_framework") {
   ]
 
   deps = [ ":universal_flutter_framework" ]
+
+  if (is_debug) {
+    deps += [ ":ios_test_flutter" ]
+  }
 }

Original file line number	Diff line number	Diff line change
`@@ -264,7 +264,6 @@ source_set("ios_test_flutter_mrc") {`
`264`	`264`	`}`
`265`	`265`
`266`	`266`	`shared_library("ios_test_flutter") {`
`267`		`- testonly = true`
`268`	`267`	`visibility = [ ":*" ]`
`269`	`268`	`cflags = [`
`270`	`269`	`"-fvisibility=default",`
`@@ -304,7 +303,6 @@ shared_library("ios_test_flutter") {`
`304`	`303`	`"framework/Source/connection_collection_test.mm",`
`305`	`304`	`]`
`306`	`305`	`deps = [`
`307`		`- ":flutter_framework",`
`308`	`306`	`":flutter_framework_source",`
`309`	`307`	`":flutter_framework_source_arc",`
`310`	`308`	`":ios_gpu_configuration",`
`@@ -467,4 +465,8 @@ action("flutter_framework") {`
`467`	`465`	`]`
`468`	`466`
`469`	`467`	`deps = [ ":universal_flutter_framework" ]`
	`468`	`+`
	`469`	`+ if (is_debug) {`
	`470`	`+ deps += [ ":ios_test_flutter" ]`
	`471`	`+ }`
`470`	`472`	`}`