Don't rethrow Dart plugin registration exceptions (#122111)

Don't rethrow Dart plugin registration exceptions

Author: stuartmorgan-g

packages/flutter_tools/lib/src/flutter_plugins.dart

@@ -703,7 +703,6 @@ const String _dartPluginRegisterWith = r'''
           '`{{pluginName}}` threw an error: $err. '
           'The app may not function as expected until you remove this plugin from pubspec.yaml'
         );
-        rethrow;
       }
 ''';
 

packages/flutter_tools/test/general.shard/build_system/targets/dart_plugin_registrant_test.dart

@@ -257,7 +257,6 @@ void main() {
           "          '`path_provider_linux` threw an error: \$err. '\n"
           "          'The app may not function as expected until you remove this plugin from pubspec.yaml'\n"
           '        );\n'
-          '        rethrow;\n'
           '      }\n'
           '\n'
           '    } else if (Platform.isMacOS) {\n'
@@ -385,7 +384,6 @@ void main() {
           "          '`path_provider_linux` threw an error: \$err. '\n"
           "          'The app may not function as expected until you remove this plugin from pubspec.yaml'\n"
           '        );\n'
-          '        rethrow;\n'
           '      }\n'
           '\n'
           '    } else if (Platform.isMacOS) {\n'

packages/flutter_tools/test/general.shard/dart_plugin_test.dart

@@ -807,7 +807,6 @@ void main() {
           "          '`url_launcher_android` threw an error: \$err. '\n"
           "          'The app may not function as expected until you remove this plugin from pubspec.yaml'\n"
           '        );\n'
-          '        rethrow;\n'
           '      }\n'
           '\n'
           '    } else if (Platform.isIOS) {\n'
@@ -818,7 +817,6 @@ void main() {
           "          '`url_launcher_ios` threw an error: \$err. '\n"
           "          'The app may not function as expected until you remove this plugin from pubspec.yaml'\n"
           '        );\n'
-          '        rethrow;\n'
           '      }\n'
           '\n'
           '    } else if (Platform.isLinux) {\n'
@@ -829,7 +827,6 @@ void main() {
           "          '`url_launcher_linux` threw an error: \$err. '\n"
           "          'The app may not function as expected until you remove this plugin from pubspec.yaml'\n"
           '        );\n'
-          '        rethrow;\n'
           '      }\n'
           '\n'
           '    } else if (Platform.isMacOS) {\n'
@@ -840,7 +837,6 @@ void main() {
           "          '`awesome_macos` threw an error: \$err. '\n"
           "          'The app may not function as expected until you remove this plugin from pubspec.yaml'\n"
           '        );\n'
-          '        rethrow;\n'
           '      }\n'
           '\n'
           '      try {\n'
@@ -850,7 +846,6 @@ void main() {
           "          '`url_launcher_macos` threw an error: \$err. '\n"
           "          'The app may not function as expected until you remove this plugin from pubspec.yaml'\n"
           '        );\n'
-          '        rethrow;\n'
           '      }\n'
           '\n'
           '    } else if (Platform.isWindows) {\n'
@@ -861,7 +856,6 @@ void main() {
           "          '`url_launcher_windows` threw an error: \$err. '\n"
           "          'The app may not function as expected until you remove this plugin from pubspec.yaml'\n"
           '        );\n'
-          '        rethrow;\n'
           '      }\n'
           '\n'
           '    }\n'