Skip to content

Commit cb40d94

Browse files
Remove dependency on web_tests/artifacts. (#160700)
We no longer pass `web_tests/artifacts` via CAS, so we need to remove it as a dependency.
1 parent 5e8b624 commit cb40d94

File tree

2 files changed

+5
-15
lines changed

2 files changed

+5
-15
lines changed

engine/src/flutter/ci/builders/linux_web_engine_test.json

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -193,18 +193,14 @@
193193
"parameters": [
194194
"check-licenses"
195195
],
196-
"scripts": [
197-
"flutter/lib/web_ui/dev/felt"
198-
]
196+
"script": "flutter/lib/web_ui/dev/felt"
199197
},
200198
{
201199
"name": "web engine analysis",
202200
"parameters": [
203201
"analyze"
204202
],
205-
"scripts": [
206-
"flutter/lib/web_ui/dev/felt"
207-
]
203+
"script": "flutter/lib/web_ui/dev/felt"
208204
}
209205
]
210206
},
@@ -220,7 +216,6 @@
220216
"download_jdk": false
221217
},
222218
"dependencies": [
223-
"web_tests/artifacts",
224219
"web_tests/test_bundles/dart2js-html-html",
225220
"web_tests/test_bundles/dart2js-html-ui",
226221
"web_tests/test_bundles/dart2js-canvaskit-engine",
@@ -412,7 +407,6 @@
412407
"download_jdk": false
413408
},
414409
"dependencies": [
415-
"web_tests/artifacts",
416410
"web_tests/test_bundles/dart2js-html-html",
417411
"web_tests/test_bundles/dart2js-html-ui",
418412
"web_tests/test_bundles/dart2js-canvaskit-engine",
@@ -540,7 +534,6 @@
540534
"download_jdk": false
541535
},
542536
"dependencies": [
543-
"web_tests/artifacts",
544537
"web_tests/test_bundles/dart2js-html-html",
545538
"web_tests/test_bundles/dart2js-html-ui",
546539
"web_tests/test_bundles/dart2js-canvaskit-engine",

engine/src/flutter/lib/web_ui/dev/generate_builder_json.dart

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -115,12 +115,12 @@ class GenerateBuilderJsonCommand extends Command<bool> {
115115
<String, dynamic>{
116116
'name': 'check licenses',
117117
'parameters': <String>['check-licenses'],
118-
'scripts': <String>['flutter/lib/web_ui/dev/felt'],
118+
'script': 'flutter/lib/web_ui/dev/felt',
119119
},
120120
<String, dynamic>{
121121
'name': 'web engine analysis',
122122
'parameters': <String>['analyze'],
123-
'scripts': <String>['flutter/lib/web_ui/dev/felt'],
123+
'script': 'flutter/lib/web_ui/dev/felt',
124124
},
125125
],
126126
};
@@ -161,10 +161,7 @@ class GenerateBuilderJsonCommand extends Command<bool> {
161161
if (cpu != null) 'cpu=$cpu',
162162
],
163163
'gclient_variables': <String, dynamic>{'download_android_deps': false, 'download_jdk': false},
164-
'dependencies': <String>[
165-
'web_tests/artifacts',
166-
...bundles.map((bundle) => 'web_tests/test_bundles/${bundle.name}'),
167-
],
164+
'dependencies': <String>[...bundles.map((bundle) => 'web_tests/test_bundles/${bundle.name}')],
168165
'test_dependencies': <dynamic>[
169166
<String, dynamic>{
170167
'dependency': 'goldctl',

0 commit comments

Comments
 (0)