PHP 8 Compatibility

berkansahin · berkansahin · commit 23173f6a8ba4 · 2021-01-07T14:28:58.000+03:00
diff --git a/Classes/PHPExcel/Worksheet.php b/Classes/PHPExcel/Worksheet.php
@@ -1474,8 +1474,10 @@ public function getConditionalStylesCollection()
      * @param $pValue PHPExcel_Style_Conditional[]
      * @return PHPExcel_Worksheet
      */
-    public function setConditionalStyles($pCoordinate = 'A1', $pValue)
+    public function setConditionalStyles($pCoordinate, $pValue)
     {
+        $pCoordinate = is_null($pCoordinate) ? 'A1' : $pCoordinate;
+
         $this->conditionalStylesCollection[strtoupper($pCoordinate)] = $pValue;
         return $this;
     }

Original file line number	Diff line number	Diff line change
`@@ -1474,8 +1474,10 @@ public function getConditionalStylesCollection()`
`1474`	`1474`	`* @param $pValue PHPExcel_Style_Conditional[]`
`1475`	`1475`	`* @return PHPExcel_Worksheet`
`1476`	`1476`	`*/`
`1477`		`- public function setConditionalStyles($pCoordinate = 'A1', $pValue)`
	`1477`	`+ public function setConditionalStyles($pCoordinate, $pValue)`
`1478`	`1478`	`{`
	`1479`	`+ $pCoordinate = is_null($pCoordinate) ? 'A1' : $pCoordinate;`
	`1480`	`+`
`1479`	`1481`	`$this->conditionalStylesCollection[strtoupper($pCoordinate)] = $pValue;`
`1480`	`1482`	`return $this;`
`1481`	`1483`	`}`