Skip to content

Conversation

@zirain
Copy link
Member

@zirain zirain commented Apr 18, 2023

What type of PR is this?

What this PR does / why we need it:

chore: update k8s.io to v0.27.1

Which issue(s) this PR fixes:

Fixes #

Signed-off-by: hejianpeng <[email protected]>
hejianpeng added 2 commits April 18, 2023 19:04
Signed-off-by: hejianpeng <[email protected]>
Signed-off-by: hejianpeng <[email protected]>
@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #1326 (8942f5d) into main (5d360cb) will decrease coverage by 0.07%.
The diff coverage is 93.75%.

@@            Coverage Diff             @@
##             main    #1326      +/-   ##
==========================================
- Coverage   61.81%   61.74%   -0.07%     
==========================================
  Files          85       85              
  Lines       10854    10854              
==========================================
- Hits         6709     6702       -7     
- Misses       3700     3706       +6     
- Partials      445      446       +1     
Impacted Files Coverage Δ
internal/provider/kubernetes/controller.go 49.05% <93.75%> (-0.45%) ⬇️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

}

func (r *gatewayAPIReconciler) enqueueManagedClass(obj client.Object) []reconcile.Request {
func (r *gatewayAPIReconciler) enqueueManagedClass(_ context.Context, obj client.Object) []reconcile.Request {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious why this API signature had to change ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@Xunzhuo Xunzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants