Skip to content
This repository was archived by the owner on Oct 5, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: hudl/react-native-android-fragment
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: ericmgoeken/react-native-android-fragment
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 13 commits
  • 1 file changed
  • 2 contributors

Commits on Nov 15, 2018

  1. Expose setAppProperties on reactRootView

    @bdwain
    bdwain authored Nov 15, 2018
    Configuration menu
    Copy the full SHA
    8035c6a View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2019

  1. reuse the view, still has issues with onDestroy killing the ReactInst… 

    …anceManager
    @ericmgoeken
    ericmgoeken committed Feb 20, 2019
    Configuration menu
    Copy the full SHA
    5abef1d View commit details
    Browse the repository at this point in the history

  2. test without destroy

    @ericmgoeken
    ericmgoeken committed Feb 20, 2019
    Configuration menu
    Copy the full SHA
    769e02e View commit details
    Browse the repository at this point in the history

  3. Merge pull request #1 from bdwain/master 

    Expose setAppProperties on reactRootView
    @ericmgoeken
    ericmgoeken authored Feb 20, 2019
    Configuration menu
    Copy the full SHA
    b90515b View commit details
    Browse the repository at this point in the history

  4. get app properties

    @ericmgoeken
    ericmgoeken committed Feb 20, 2019
    Configuration menu
    Copy the full SHA
    6da6e4d View commit details
    Browse the repository at this point in the history

  5. Merge branch 'feature/get-app-properties' into dev

    @ericmgoeken
    ericmgoeken committed Feb 20, 2019
    Configuration menu
    Copy the full SHA
    d25d985 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2019

  1. uncomment

    @ericmgoeken
    ericmgoeken committed Feb 21, 2019
    Configuration menu
    Copy the full SHA
    9735633 View commit details
    Browse the repository at this point in the history

  2. Add BEFORE_RESUME as an acceptable Lifecycle State to keep the instan… 

    …ce manager alive.
    @ericmgoeken
    ericmgoeken committed Feb 21, 2019
    Configuration menu
    Copy the full SHA
    dba150d View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2019

  1. add null check

    @ericmgoeken
    ericmgoeken committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    573a941 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'feature/reuse-react-view' into dev

    @ericmgoeken
    ericmgoeken committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    13c955f View commit details
    Browse the repository at this point in the history

  3. Merge branch 'feature/get-app-properties' into dev

    @ericmgoeken
    ericmgoeken committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    f2ced70 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2019

  1. Merge pull request #2 from hudl/master 

    Fork Update
    @ericmgoeken
    ericmgoeken authored Jun 23, 2019
    Configuration menu
    Copy the full SHA
    58ace44 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into dev

    @ericmgoeken
    ericmgoeken committed Jun 23, 2019
    Configuration menu
    Copy the full SHA
    12ca7e6 View commit details
    Browse the repository at this point in the history
Loading