forked from mysticatea/eslint-plugin-node
-
-
Notifications
You must be signed in to change notification settings - Fork 55
feat: support eslint.config.js #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
9c0e322
feat: support eslint.config.js (fixes #89)
aladdin-add cc19d35
fix: add languageOptions
aladdin-add 97d3d09
docs: add link to eslint docs
aladdin-add dea40ad
chore: dogfooding the new config
aladdin-add a3a0dfb
chore: fix linting errors
aladdin-add 58cbfcb
chore: add metadata in the exported object
aladdin-add ccfbeb3
fix: config.plugins
aladdin-add 52125ff
fix: add globals config
aladdin-add 4eea92b
chore: update eslint config
aladdin-add e5585fa
chore: use predefined eslint:recommended
aladdin-add 4979148
fix: global ignores should not be used with other keys
aladdin-add 5fc4dac
fix: remove recommended config
aladdin-add dcf6f66
chore: update eslint.config.js
aladdin-add File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
chore: dogfooding the new config
- Loading branch information
commit dea40ad3a1a11d90741f976523ba860cda4f9c1c
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,27 @@ | ||||||||
| /** | ||||||||
| * @author 唯然<[email protected]> | ||||||||
| */ | ||||||||
| "use strict" | ||||||||
|
|
||||||||
| const js = require("@eslint/js") | ||||||||
| const { FlatCompat } = require("@eslint/eslintrc") | ||||||||
| const globals = require("globals") | ||||||||
| const nodeRecommended = require("eslint-plugin-n/configs/recommended-script") | ||||||||
|
|
||||||||
| const compat = new FlatCompat({ | ||||||||
| baseDirectory: __dirname, | ||||||||
| recommendedConfig: js.configs.recommended, | ||||||||
| }) | ||||||||
|
|
||||||||
| module.exports = [ | ||||||||
mdjermanovic marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||
| ...compat.extends( | ||||||||
| "eslint:recommended", | ||||||||
| "plugin:eslint-plugin/recommended", | ||||||||
| "prettier" | ||||||||
| ), | ||||||||
| nodeRecommended, | ||||||||
| { | ||||||||
| languageOptions: { globals: globals.mocha }, | ||||||||
| linterOptions: { reportUnusedDisableDirectives: true }, | ||||||||
| }, | ||||||||
| ] | ||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Compared to the previous (.eslintrc.js) config, this one might be missing this rule: Lines 20 to 22 in bea9981
|
||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.