Skip to content

Commit e32df71

Browse files
authored
chore: update eslint-plugin-eslint-comments, remove legacy-peer-deps (#20576)
* chore: update eslint-plugin-eslint-comments, remove legacy-peer-deps * bump eslint-plugin-eslint-comments * restore some `--legacy-peer-deps`
1 parent 23b2759 commit e32df71

File tree

4 files changed

+7
-8
lines changed

4 files changed

+7
-8
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -145,11 +145,11 @@ jobs:
145145

146146
- name: Install Packages for ${{ matrix.package.name }}
147147
working-directory: ${{ matrix.package.directory }}
148-
run: npm install --legacy-peer-deps
148+
run: npm install
149149

150150
- name: Install TypeScript ${{ matrix.typescript }}
151151
working-directory: ${{ matrix.package.directory }}
152-
run: npm install --legacy-peer-deps --no-save typescript@${{ matrix.typescript }}
152+
run: npm install --no-save typescript@${{ matrix.typescript }}
153153

154154
- name: Test types for ${{ matrix.package.name }}
155155
working-directory: ${{ matrix.package.directory }}

.github/workflows/types-integration.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ jobs:
3636
- name: Install Packages (eslint-webpack-plugin)
3737
working-directory: webpack
3838
run: |
39-
npm install --no-package-lock --legacy-peer-deps ../eslint
39+
npm install --no-package-lock ../eslint
4040
4141
- name: Run TSC
4242
working-directory: webpack
@@ -68,7 +68,7 @@ jobs:
6868
- name: Install Packages (neostandard)
6969
working-directory: neostandard
7070
run: |
71-
npm ci && npm install --no-save --legacy-peer-deps ../eslint
71+
npm ci && npm install --no-save ../eslint
7272
7373
- name: Run TSC
7474
working-directory: neostandard
@@ -100,7 +100,7 @@ jobs:
100100
- name: Install Packages (eslint-flat-config-utils)
101101
working-directory: antfu
102102
run: |
103-
npm install --legacy-peer-deps ../eslint
103+
npm install ../eslint
104104
105105
- name: Run TSC
106106
working-directory: antfu
@@ -240,7 +240,7 @@ jobs:
240240

241241
- name: Install Packages
242242
working-directory: ${{ matrix.package.directory }}
243-
run: npm install --legacy-peer-deps
243+
run: npm install
244244

245245
- name: Check validity of type definitions
246246
working-directory: ${{ matrix.package.directory }}

.npmrc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,2 @@
11
package-lock = false
22
install-links = false
3-
legacy-peer-deps = true

packages/eslint-config-eslint/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@
6262
"homepage": "https://eslint.org",
6363
"bugs": "https://github.com/eslint/eslint/issues/",
6464
"dependencies": {
65-
"@eslint-community/eslint-plugin-eslint-comments": "^4.3.0",
65+
"@eslint-community/eslint-plugin-eslint-comments": "^4.7.1",
6666
"@eslint/js": "^10.0.1",
6767
"eslint-plugin-jsdoc": "^62.7.0",
6868
"eslint-plugin-n": "^17.11.1",

0 commit comments

Comments
 (0)