feat: add no-reference-like-urls rule#433
Merged
Merged
Conversation
snitin315
reviewed
Jun 23, 2025
snitin315
previously approved these changes
Jun 26, 2025
snitin315
left a comment
snitin315
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks. Leaving it open for 2nd review.
lumirlumir
requested changes
Jun 26, 2025
lumirlumir
reviewed
Jun 26, 2025
JoshuaKGoldberg
previously approved these changes
Jun 26, 2025
JoshuaKGoldberg
left a comment
JoshuaKGoldberg
left a comment
Contributor
There was a problem hiding this comment.
Looking good! No requests from me that aren't already noted. Thanks! 🚀
lumirlumir
requested changes
Jun 30, 2025
Member
|
@lumirlumir please take a look at the responses to your comments. |
lumirlumir
requested changes
Jul 12, 2025
lumirlumir
left a comment
lumirlumir
left a comment
Member
There was a problem hiding this comment.
Sorry for the delay on my end. I've responded to your previous comment.
lumirlumir
requested changes
Jul 21, 2025
lumirlumir
requested changes
Jul 29, 2025
lumirlumir
left a comment
lumirlumir
left a comment
Member
There was a problem hiding this comment.
Nice improvements! I’ve left a few comments about some other cases that are missing.
lumirlumir
changed the title
lumirlumir
requested changes
Aug 4, 2025
lumirlumir
previously approved these changes
Aug 5, 2025
lumirlumir
left a comment
lumirlumir
left a comment
Member
There was a problem hiding this comment.
LGTM, Would like @snitin315 to verify the changes before merging.
snitin315
reviewed
Aug 9, 2025
snitin315
left a comment
snitin315
left a comment
Contributor
There was a problem hiding this comment.
The following case doesn't report any errors, is this expected behavior?
<!-- eslint markdown/no-reference-like-urls: "error" -->
[Mercury]( mercury) is the first planet from the sun.
[mercury]: https://example.com/mercury/
snitin315
requested changes
Aug 9, 2025
Contributor
Author
|
@snitin315 This should be fixed now. |
Member
|
ping @snitin315 |
nzakas
approved these changes
Sep 9, 2025
nzakas
left a comment
nzakas
left a comment
Member
There was a problem hiding this comment.
Since it's been over a month and I've verified the changes, I'm going to merge this.
github-project-automation
Bot
moved this from Second Review Needed
to Complete
in Triage
Merged
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Add a new rule, no-reference-like-url, to disallow inline links or images when the URL matches a defined reference identifier.
What changes did you make? (Give an overview)
Implemented the no-reference-like-url rule with autofix, added documentation, and included tests.
Related Issues
Fixes #419
Is there anything you'd like reviewers to focus on?