Tightup implementation.

Author: razvanpaulp

essentialprogramming-api/src/main/java/com/api/config/MetricsFilter.java

@@ -28,7 +28,7 @@ public MetricsFilter(ResourceInfo resourceInfo, MeterRegistry meterRegistry) {
 
         counters.put(fullMethodName, Counter
                 .builder(METRIC_KEY + "." + controllerName + "." + methodName)
-                .description("count of endpoint calls " + getHttpMethod(resourceInfo) + " : " + endpointPath)
+                .description("counter of API requests " + getHttpMethod(resourceInfo) + " : " + endpointPath)
                 .register(meterRegistry));
     }
 

essentialprogramming-api/src/main/java/com/config/MicrometerConfig.java

@@ -13,23 +13,25 @@
 import io.micrometer.datadog.DatadogMeterRegistry;
 import io.micrometer.jmx.JmxConfig;
 import io.micrometer.jmx.JmxMeterRegistry;
+import lombok.extern.slf4j.Slf4j;
 import org.springframework.context.annotation.Bean;
 import org.springframework.context.annotation.Configuration;
 
 import java.security.GeneralSecurityException;
 import java.time.Duration;
 
 @Configuration
+@Slf4j
 public class MicrometerConfig {
     private static final String DECRYPTION_KEY = "supercalifragilisticexpialidocious";
 
     @Bean(name = "microMeterRegistry")
     public MeterRegistry meterRegistry() {
 
         final CompositeMeterRegistry compositeRegistry = new CompositeMeterRegistry();
-        final SimpleMeterRegistry oneSimpleMeter = new SimpleMeterRegistry();
+        final MeterRegistry oneSimpleMeter = new SimpleMeterRegistry();
         final MeterRegistry jmxRegistry = new JmxMeterRegistry(JmxConfig.DEFAULT, Clock.SYSTEM);
-        final DatadogMeterRegistry datadogMeterRegistry = new DatadogMeterRegistry(configureDatadog(), Clock.SYSTEM);
+        final MeterRegistry datadogMeterRegistry = new DatadogMeterRegistry(configureDatadog(), Clock.SYSTEM);
 
         compositeRegistry.add(oneSimpleMeter);
         compositeRegistry.add(jmxRegistry);
@@ -85,14 +87,19 @@ public boolean descriptions() {
         };
     }
 
-    private static String decryptKey(AppResources appResources) {
+    private static String decryptKey(final AppResources appResources) {
         try {
             return Crypt.decrypt(appResources.value(), DECRYPTION_KEY);
         } catch (GeneralSecurityException e) {
-
-            if (appResources.equals(AppResources.DATADOG_API_KEY)) {
+            if (AppResources.DATADOG_API_KEY.equals(appResources)) {
+                log.error(ErrorCode.UNABLE_TO_DECRYPT_API_KEY.getCode(), ErrorCode.UNABLE_TO_DECRYPT_API_KEY.getDescription());
                 throw new ServiceException(ErrorCode.UNABLE_TO_DECRYPT_API_KEY, e);
-            } else throw new ServiceException(ErrorCode.UNABLE_TO_DECRYPT_APPLICATION_KEY, e);
+            }
+            if (AppResources.DATADOG_APPLICATION_KEY.equals(appResources)) {
+                log.error(ErrorCode.UNABLE_TO_DECRYPT_APPLICATION_KEY.getCode(), ErrorCode.UNABLE_TO_DECRYPT_APPLICATION_KEY.getDescription());
+                throw new ServiceException(ErrorCode.UNABLE_TO_DECRYPT_APPLICATION_KEY, e);
+            }
+            throw new RuntimeException("Wrong argument provided", e);
         }
     }
 }