Merge pull request scala#2693 from lexspoon/semmle-lint

Lint-like fixes found by Semmle

Author: adriaanm

.gitignore

@@ -0,0 +1 @@
+build

lib/.gitignore

@@ -0,0 +1,15 @@
+ant-contrib.jar
+ant-dotnet-1.0.jar
+ant.jar
+fjbg.jar
+forkjoin.jar
+jline.jar
+maven-ant-tasks-2.1.1.jar
+msil.jar
+scala-compiler.jar
+scala-compiler-src.jar
+scala-library.jar
+scala-library-src.jar
+scala-reflect.jar
+scala-reflect-src.jar
+vizant.jar

src/compiler/scala/tools/ant/sabbus/Settings.scala

@@ -93,4 +93,18 @@ class Settings {
     case _ => false
   }
 
+  override lazy val hashCode: Int = Seq(
+    gBf,
+    uncheckedBf,
+    classpathBf,
+    sourcepathBf,
+    sourcedirBf,
+    bootclasspathBf,
+    extdirsBf,
+    dBf,
+    encodingBf,
+    targetBf,
+    optimiseBf,
+    extraParamsBf
+  ).##
 }

src/compiler/scala/tools/nsc/backend/icode/GenICode.scala

@@ -1748,7 +1748,7 @@ abstract class GenICode extends SubComponent  {
 
     /////////////////////// Context ////////////////////////////////
 
-    abstract class Cleanup(val value: AnyRef) {
+    sealed abstract class Cleanup(val value: AnyRef) {
       def contains(x: AnyRef) = value == x
     }
     case class MonitorRelease(m: Local) extends Cleanup(m) { }

src/compiler/scala/tools/nsc/backend/icode/Members.scala

@@ -108,6 +108,14 @@ trait Members {
       if (symbol eq other.symbol) 0
       else if (symbol isLess other.symbol) -1
       else 1
+
+    override def equals(other: Any): Boolean =
+      other match {
+        case other: IMember => (this compare other) == 0
+        case _ => false
+      }
+
+    override def hashCode = symbol.##
   }
 
   /** Represent a class in ICode */

src/compiler/scala/tools/nsc/backend/icode/analysis/CopyPropagation.scala

@@ -27,7 +27,7 @@ abstract class CopyPropagation {
   case object This extends Location
 
   /** Values that can be on the stack. */
-  abstract class Value { }
+  sealed abstract class Value { }
   case class Record(cls: Symbol, bindings: mutable.Map[Symbol, Value]) extends Value { }
   /** The value of some location in memory. */
   case class Deref(l: Location) extends Value

src/compiler/scala/tools/nsc/dependencies/Changes.scala

@@ -16,7 +16,7 @@ abstract class Changes {
   import compiler._
   import symtab.Flags._
 
-  abstract class Change
+  sealed abstract class Change
 
   private lazy val annotationsChecked =
     List(definitions.SpecializedClass) // Any others that should be checked?
@@ -38,7 +38,7 @@ abstract class Changes {
   /** An entity in source code, either a class or a member definition.
    *  Name is fully-qualified.
    */
-  abstract class Entity
+  sealed abstract class Entity
   case class Class(name: String) extends Entity
   case class Definition(name: String) extends Entity
 

src/compiler/scala/tools/nsc/settings/ScalaVersion.scala

@@ -11,7 +11,7 @@ package tools.nsc.settings
  * Represents a single Scala version in a manner that
  * supports easy comparison and sorting.
  */
-abstract class ScalaVersion extends Ordered[ScalaVersion] {
+sealed abstract class ScalaVersion extends Ordered[ScalaVersion] {
   def unparse: String
 }
 

src/compiler/scala/tools/nsc/transform/patmat/MatchTreeMaking.scala

@@ -79,7 +79,7 @@ trait MatchTreeMaking extends MatchCodeGen with Debugging {
       def chainBefore(next: Tree)(casegen: Casegen): Tree
     }
 
-    trait NoNewBinders extends TreeMaker {
+    sealed trait NoNewBinders extends TreeMaker {
       protected val localSubstitution: Substitution = EmptySubstitution
     }
 
@@ -105,12 +105,12 @@ trait MatchTreeMaking extends MatchCodeGen with Debugging {
       override def toString = "S"+ localSubstitution
     }
 
-    abstract class FunTreeMaker extends TreeMaker {
+    sealed abstract class FunTreeMaker extends TreeMaker {
       val nextBinder: Symbol
       def pos = nextBinder.pos
     }
 
-    abstract class CondTreeMaker extends FunTreeMaker {
+    sealed abstract class CondTreeMaker extends FunTreeMaker {
       val prevBinder: Symbol
       val nextBinderTp: Type
       val cond: Tree
@@ -126,7 +126,7 @@ trait MatchTreeMaking extends MatchCodeGen with Debugging {
     // unless we're optimizing, emit local variable bindings for all subpatterns of extractor/case class patterns
     protected val debugInfoEmitVars = !settings.optimise.value
 
-    trait PreserveSubPatBinders extends TreeMaker {
+    sealed trait PreserveSubPatBinders extends TreeMaker {
       val subPatBinders: List[Symbol]
       val subPatRefs: List[Tree]
       val ignoredSubPatBinders: Set[Symbol]

src/compiler/scala/tools/nsc/typechecker/ContextErrors.scala

@@ -21,13 +21,13 @@ trait ContextErrors {
   import global._
   import definitions._
 
-  abstract class AbsTypeError extends Throwable {
+  sealed abstract class AbsTypeError extends Throwable {
     def errPos: Position
     def errMsg: String
     override def toString() = "[Type error at:" + errPos + "] " + errMsg
   }
 
-  abstract class TreeTypeError extends AbsTypeError {
+  sealed abstract class TreeTypeError extends AbsTypeError {
     def underlyingTree: Tree
     def errPos = underlyingTree.pos
   }