Updated files to PEP8, documentation, format => f-string, refactor a couple of functions #711
Conversation
Miscopied "Stopped" instead of "Started".
telebot/__init__.py
Outdated
| class Handler: | ||
| """ | ||
| Class for (next step|reply) handlers | ||
| Class for (next steplogger.debug|reply) handlers |
|
|
||
| self.token = token | ||
| self.update_listener = [] | ||
| self.update_listener = list() |
There was a problem hiding this comment.
What is the reason (here and below)? Nothing in PEP8 about it?
And here they say that it is slower: https://stackoverflow.com/questions/2972212/creating-an-empty-list-in-python
There was a problem hiding this comment.
Perhaps not really the best change. It just reads better.
telebot/types.py
Outdated
| "url" : "<a href=\"{url}\">{text}</a>", | ||
| "text_link": "<a href=\"{url}\">{text}</a>" | ||
| } | ||
| _subs = dict(bold="<b>{text}</b>", italic="<i>{text}</i>", pre="<pre>{text}</pre>", code="<code>{text}</code>", |
There was a problem hiding this comment.
Single item per single line pls...
|
Итого. Просьба, если есть возможность:
PS. Благодаря уважаемому eternnoir у меня появились ключи от сейфа, можно попробовать освежить этот неплохой продукт. :) |
|
Problems with f-strings and python 2.7 & 3.5... 3.5 is not at EOL... :( |
|
:/ |
|
Hm. 16 more edited files instead of clearing previous ones. Me personally do not like the formatting style you bring. I did not like the previous one, I do not like new one even more. So I cannot accept this request, sorry. May be someone else did it. I manually bring all (as far as I found them in 22 files) valuable updates to the pull request #728. That's all I can do for it now. |
|
Ok |
|
No need to close the issue. I'm not the one with final decisions. It was my personal oppinion, owner may have another one. |
2 participants
Uh oh!
There was an error while loading. Please reload this page.