Merge pull request careercup#3 from careercup/gitignore

Gitignore

Author: dawsbot

.gitignore

@@ -0,0 +1,8 @@
+node_modules
+
+# Logs
+logs
+*.log
+
+# Mac specific
+DS_Store

README.md

@@ -1,22 +1,23 @@
-####Run the code and test
-This project uses Mocha and Chai for testing:
+# Cracking the Coding Interview 6th Edition - JavaScript
 
 <br>
-#####Install dependencies:
+
+## Install dependencies:
 ```bash
 npm install
-npm install -g mocha
-npm install -g chai
 ```
 
 <br>
-#####Run tests:
+
+## Test
+
 ```bash
-mocha --recursive
+npm test
 ```
 
-<br>
-#####Add new npm modules:
+If you just want to lint  
 ```bash
-npm install --save <package name>
+npm run lint
 ```
+
+<br>

lib/data-structures/chapter-1/1_8.js

@@ -1,15 +1,21 @@
 module.exports = Strings_1_8 = (function() {
-  var _isSubstring = function(str1, str2) {
-    return str1.indexOf(str2) != -1
-  }
-  var _sameLengthAndNotBlank = function(str1, str2) {
+  var isSubstring = function(str1, str2) {
+    return str1.indexOf(str2) != -1;
+  };
+
+  var sameLengthAndNotBlank = function(str1, str2) {
     var len = str1.length;
-    return len === str2.length && len > 0
-  }
+    return len === str2.length && len > 0;
+  };
+
   return {
     isRotation: function(str1, str2) {
-      if(!_sameLengthAndNotBlank(str1, str2)) return false;
-      if(_isSubstring(str1+str1, str2)) return true;
+      if(!sameLengthAndNotBlank(str1, str2)) {
+        return false;
+      }
+      if(isSubstring(str1+str1, str2)) {
+        return true;
+      }
     }
-  }
+  };
 }());

package.json

@@ -2,12 +2,16 @@
   "name": "CrackingJS",
   "version": "0.0.1",
   "description": "Data Structures and Algorithms in Javascript",
+  "scripts": {
+    "lint": "eslint lib/**/*.js test/**/*.js",
+    "test": "npm run lint && mocha --recursive"
+  },
   "dependencies": {
-    "mocha": "*",
     "chai": "*",
+    "eslint": "^2.2.0",
+    "mocha": "*",
     "require-directory": "*",
     "sinon": "*"
   },
-  "devDependencies": {
-  }
+  "devDependencies": {}
 }

test/test_helper.js

@@ -1,3 +1,3 @@
 require('../lib');
-module.exports = sinon = require("sinon");
-module.exports = expect = require("chai").expect
+module.exports = sinon = require('sinon');
+module.exports = expect = require('chai').expect;