Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: expressjs/compression
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: Icehunter/compression
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: bugfix/use_writeHead_instead_of_implicitHeader
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 19 commits
  • 2 files changed
  • 5 contributors

Commits on Jul 30, 2022

  1. Add failing tests for http2

    @Icehunter
    Moritz Peters authored and Icehunter committed Jul 30, 2022
    Configuration menu
    Copy the full SHA
    f160f44 View commit details
    Browse the repository at this point in the history

  2. Add support for http2 

    The change just removes the usage of undocumented http API and instead uses the proper writeHead method
    @Icehunter
    Moritz Peters authored and Icehunter committed Jul 30, 2022
    Configuration menu
    Copy the full SHA
    2c8ed82 View commit details
    Browse the repository at this point in the history

  3. Remove arrow function in tests

    @Icehunter
    Moritz Peters authored and Icehunter committed Jul 30, 2022
    Configuration menu
    Copy the full SHA
    8eae006 View commit details
    Browse the repository at this point in the history

  4. Conditionally run http2 tests if http2 is available

    @Icehunter
    Moritz Peters authored and Icehunter committed Jul 30, 2022
    Configuration menu
    Copy the full SHA
    8c68bc1 View commit details
    Browse the repository at this point in the history

  5. Fix port in tests to be assigned automatically

    @Icehunter
    Moritz Peters authored and Icehunter committed Jul 30, 2022
    Configuration menu
    Copy the full SHA
    5122916 View commit details
    Browse the repository at this point in the history

  6. Change http2 test usage to describe.skip if no http2 available

    @Icehunter
    Moritz Peters authored and Icehunter committed Jul 30, 2022
    Configuration menu
    Copy the full SHA
    7b7f506 View commit details
    Browse the repository at this point in the history

  7. Fix closing the http2 connections to prevent possible exceptions

    @Icehunter
    Moritz Peters authored and Icehunter committed Jul 30, 2022
    Configuration menu
    Copy the full SHA
    8ba8100 View commit details
    Browse the repository at this point in the history

  8. Fix closing the request first, then the client, then the server

    @Icehunter
    Moritz Peters authored and Icehunter committed Jul 30, 2022
    Configuration menu
    Copy the full SHA
    8ea806d View commit details
    Browse the repository at this point in the history

  9. Fix closing for v8.x and v9.x

    @Icehunter
    Moritz Peters authored and Icehunter committed Jul 30, 2022
    Configuration menu
    Copy the full SHA
    a562056 View commit details
    Browse the repository at this point in the history

  10. fix tests not draining data for http2 requests, resulting in timeouts… 

    … in node v10.4 onwards
    @maritz @Icehunter
    maritz authored and Icehunter committed Jul 30, 2022
    Configuration menu
    Copy the full SHA
    feddec1 View commit details
    Browse the repository at this point in the history

  11. fix: 🐛 assert.equal error

    @Icehunter
    Icehunter committed Jul 30, 2022
    Configuration menu
    Copy the full SHA
    5124eb0 View commit details
    Browse the repository at this point in the history

  12. fix: 🐛 remove console.log's and timeout, let build fail

    @Icehunter
    Icehunter committed Jul 30, 2022
    Configuration menu
    Copy the full SHA
    094316e View commit details
    Browse the repository at this point in the history

  13. Apply suggestions from code review 

    Co-authored-by: Lam Wei Li <[email protected]>
    @Icehunter @lamweili
    Icehunter and lamweili committed Jul 30, 2022
    Configuration menu
    Copy the full SHA
    d85e6e8 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2022

  1. fixed lint

    @Icehunter @lamweili
    Icehunter authored and lamweili committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    d3016e2 View commit details
    Browse the repository at this point in the history

  2. fix: an issue where test hangs when assertion fails in http2 as http2… 

    …server is not closed
    @lamweili
    lamweili committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    ebae4e9 View commit details
    Browse the repository at this point in the history

  3. refactor: use http2.constants instead of hard-coded strings in http2 … 

    …test
    @lamweili
    lamweili committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    78cac20 View commit details
    Browse the repository at this point in the history

  4. Node.js 0.8 compatible

    @lamweili
    lamweili committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    4c1d27b View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2024

  1. Merge branch 'master' into bugfix/use_writeHead_instead_of_implicitHe… 

    …ader
    @bjohansebas
    bjohansebas authored Nov 9, 2024
    Configuration menu
    Copy the full SHA
    ec797a7 View commit details
    Browse the repository at this point in the history

  2. fix lint issue

    @Icehunter
    Icehunter committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    c126f78 View commit details
    Browse the repository at this point in the history
Loading