Skip to content

Fix usage of undocumented _implicitHeader #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

Fix usage of undocumented _implicitHeader #128

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
769f52b
Add failing tests for http2
Jan 10, 2018
6e1ae36
Add support for http2
Jan 10, 2018
f4e4dfc
Remove arrow function in tests
Jan 10, 2018
b00e4f6
Conditionally run http2 tests if http2 is available
Jan 10, 2018
655bbe9
Add node versions to travis config that have http2
Jan 15, 2018
eb2e280
Fix port in tests to be assigned automatically
Jan 15, 2018
8d45e7e
Change http2 test usage to describe.skip if no http2 available
Jan 15, 2018
ce237f3
Fix closing the http2 connections to prevent possible exceptions
Jan 15, 2018
75794dd
Fix closing the request first, then the client, then the server
Jan 15, 2018
521863c
Fix closing for v8.x and v9.x
Jan 15, 2018
19a6ac5
fix tests not draining data for http2 requests, resulting in timeouts…
maritz Sep 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add support for http2 
The change just removes the usage of undocumented http API and instead uses the proper writeHead method
  • Loading branch information
@maritz
Moritz Peters authored and maritz committed Sep 26, 2018
commit 6e1ae362b5f8b4f3b1ac801d93cbf64e340d0a51
4 changes: 2 additions & 2 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ function compression (options) {
}

if (!this._header) {
this._implicitHeader()
this.writeHead(this.statusCode)
}

return stream
Expand All @@ -100,7 +100,7 @@ function compression (options) {
length = chunkLength(chunk, encoding)
}

this._implicitHeader()
this.writeHead(this.statusCode)
}

if (!stream) {
Expand Down