Skip to content

Commit c0136d8

Browse files
committed
Add express.json and express.urlencoded to parse bodies
closes #2211
1 parent 86f5df0 commit c0136d8

File tree

8 files changed

+11
-14
lines changed

8 files changed

+11
-14
lines changed

History.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ unreleased
22
==========
33

44
* Add `"json escape"` setting for `res.json` and `res.jsonp`
5+
* Add `express.json` and `express.urlencoded` to parse bodies
56
* Improve error message when autoloading invalid view engine
67
* Improve error messages when non-function provided as middleware
78
* Skip `Buffer` encoding when not generating ETag for small response

examples/auth/index.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
*/
44

55
var express = require('../..');
6-
var bodyParser = require('body-parser');
76
var hash = require('pbkdf2-password')()
87
var path = require('path');
98
var session = require('express-session');
@@ -17,7 +16,7 @@ app.set('views', path.join(__dirname, 'views'));
1716

1817
// middleware
1918

20-
app.use(bodyParser.urlencoded({ extended: false }));
19+
app.use(express.urlencoded({ extended: false }))
2120
app.use(session({
2221
resave: false, // don't save session if unmodified
2322
saveUninitialized: false, // don't create session until something stored

examples/cookies/index.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ var express = require('../../');
66
var app = module.exports = express();
77
var logger = require('morgan');
88
var cookieParser = require('cookie-parser');
9-
var bodyParser = require('body-parser');
109

1110
// custom log format
1211
if ('test' != process.env.NODE_ENV) app.use(logger(':method :url'));
@@ -18,7 +17,7 @@ if ('test' != process.env.NODE_ENV) app.use(logger(':method :url'));
1817
app.use(cookieParser('my secret here'));
1918

2019
// parses x-www-form-urlencoded
21-
app.use(bodyParser.urlencoded({ extended: false }));
20+
app.use(express.urlencoded({ extended: false }))
2221

2322
app.get('/', function(req, res){
2423
if (req.cookies.remember) {

examples/mvc/index.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ var express = require('../..');
66
var logger = require('morgan');
77
var path = require('path');
88
var session = require('express-session');
9-
var bodyParser = require('body-parser');
109
var methodOverride = require('method-override');
1110

1211
var app = module.exports = express();
@@ -43,7 +42,7 @@ app.use(session({
4342
}));
4443

4544
// parse request bodies (req.body)
46-
app.use(bodyParser.urlencoded({ extended: true }));
45+
app.use(express.urlencoded({ extended: true }))
4746

4847
// allow overriding methods in query (?_method=put)
4948
app.use(methodOverride('_method'));

examples/route-separation/index.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ var path = require('path');
77
var app = express();
88
var logger = require('morgan');
99
var cookieParser = require('cookie-parser');
10-
var bodyParser = require('body-parser');
1110
var methodOverride = require('method-override');
1211
var site = require('./site');
1312
var post = require('./post');
@@ -27,7 +26,7 @@ if (!module.parent) {
2726

2827
app.use(methodOverride('_method'));
2928
app.use(cookieParser());
30-
app.use(bodyParser.urlencoded({ extended: true }));
29+
app.use(express.urlencoded({ extended: true }))
3130
app.use(express.static(path.join(__dirname, 'public')));
3231

3332
// General

lib/express.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
* Module dependencies.
1313
*/
1414

15+
var bodyParser = require('body-parser')
1516
var EventEmitter = require('events').EventEmitter;
1617
var mixin = require('merge-descriptors');
1718
var proto = require('./application');
@@ -74,16 +75,16 @@ exports.Router = Router;
7475
* Expose middleware
7576
*/
7677

78+
exports.json = bodyParser.json
7779
exports.query = require('./middleware/query');
7880
exports.static = require('serve-static');
81+
exports.urlencoded = bodyParser.urlencoded
7982

8083
/**
8184
* Replace removed middleware with an appropriate error message.
8285
*/
8386

84-
[
85-
'json',
86-
'urlencoded',
87+
;[
8788
'bodyParser',
8889
'compress',
8990
'cookieSession',

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
"dependencies": {
3030
"accepts": "~1.3.4",
3131
"array-flatten": "1.1.1",
32+
"body-parser": "1.18.2",
3233
"content-disposition": "0.5.2",
3334
"content-type": "~1.0.4",
3435
"cookie": "0.3.1",
@@ -59,7 +60,6 @@
5960
},
6061
"devDependencies": {
6162
"after": "0.8.2",
62-
"body-parser": "1.18.2",
6363
"cookie-parser": "~1.4.3",
6464
"cookie-session": "1.3.2",
6565
"ejs": "2.5.7",

test/req.param.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11

22
var express = require('../')
33
, request = require('supertest')
4-
, bodyParser = require('body-parser')
54

65
describe('req', function(){
76
describe('.param(name, default)', function(){
@@ -34,7 +33,7 @@ describe('req', function(){
3433
it('should check req.body', function(done){
3534
var app = express();
3635

37-
app.use(bodyParser.json());
36+
app.use(express.json())
3837

3938
app.use(function(req, res){
4039
res.end(req.param('name'));

0 commit comments

Comments
 (0)