Skip to content

Commit ba9dd68

Browse files
haowu14facebook-github-bot
authored andcommitted
Change some of the stats to rate
Summary: As mentioned in the tasks, these stats make more sense in rates. Reviewed By: jiayuebao Differential Revision: D43243498 fbshipit-source-id: 556b0b4a062235bb3b34dd076e5f7a5a88316f8c
1 parent ba8d6b0 commit ba9dd68

File tree

2 files changed

+10
-5
lines changed

2 files changed

+10
-5
lines changed

cachelib/navy/block_cache/BlockCache.cpp

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -723,9 +723,11 @@ void BlockCache::getCounters(const CounterVisitor& visitor) const {
723723
reclaimValueChecksumErrorCount_.get(),
724724
CounterVisitor::CounterType::RATE);
725725
visitor("navy_bc_cleanup_entry_header_checksum_errors",
726-
cleanupEntryHeaderChecksumErrorCount_.get());
726+
cleanupEntryHeaderChecksumErrorCount_.get(),
727+
CounterVisitor::CounterType::RATE);
727728
visitor("navy_bc_cleanup_value_checksum_errors",
728-
cleanupValueChecksumErrorCount_.get());
729+
cleanupValueChecksumErrorCount_.get(),
730+
CounterVisitor::CounterType::RATE);
729731
visitor("navy_bc_succ_lookups", succLookupCount_.get(),
730732
CounterVisitor::CounterType::RATE);
731733
visitor("navy_bc_removes", removeCount_.get(),
@@ -750,7 +752,8 @@ void BlockCache::getCounters(const CounterVisitor& visitor) const {
750752
visitor("navy_bc_reinsertion_errors", reinsertionErrorCount_.get(),
751753
CounterVisitor::CounterType::RATE);
752754
visitor("navy_bc_lookup_for_item_destructor_errors",
753-
lookupForItemDestructorErrorCount_.get());
755+
lookupForItemDestructorErrorCount_.get(),
756+
CounterVisitor::CounterType::RATE);
754757
visitor("navy_bc_remove_attempt_collisions", removeAttemptCollisions_.get(),
755758
CounterVisitor::CounterType::RATE);
756759
// Allocator visits region manager

cachelib/navy/driver/Driver.cpp

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -273,8 +273,10 @@ void Driver::getCounters(const CounterVisitor& visitor) const {
273273
CounterVisitor::CounterType::RATE);
274274
visitor("navy_rejected_bytes", rejectedBytes_.get(),
275275
CounterVisitor::CounterType::RATE);
276-
visitor("navy_accepted_bytes", acceptedBytes_.get());
277-
visitor("navy_accepted", acceptedCount_.get());
276+
visitor("navy_accepted_bytes", acceptedBytes_.get(),
277+
CounterVisitor::CounterType::RATE);
278+
visitor("navy_accepted", acceptedCount_.get(),
279+
CounterVisitor::CounterType::RATE);
278280

279281
visitor("navy_parcel_memory", parcelMemory_.get());
280282
visitor("navy_concurrent_inserts", concurrentInserts_.get());

0 commit comments

Comments
 (0)