create-react-app deletes error.log when aborting an installation

[mg]

I know what the error was (Im running behind a proxy that inspects requests and causes no ends of problems) but the fact that create-react-app automatically deletes the error log could be problematic.

1. create-react-app encounters an error while creating an app
2. cra logs the error into ./myApp/yarn-errror.log
3. cra aborts the installation
4. cra deletes the yarn-error.log

[Timer]

I would welcome a PR which leaves the log files (for npm and Yarn) intact.

[gaearon]

... and then disregards them when creating a project next time (instead of warning about overwriting files).

[mg]

the create-react-app explicitly deletes five files on a failed installation:

 'package.json',
 'npm-debug.log',
 'yarn-error.log',
 'yarn-debug.log',
 'node_modules'

Is there ever a good reason to delete npm-debug.log, yarn-error.log or yarn-debug-log on a failed installation?

[Timer]

No, but we thought it was at one point!
You can remove those from the deleted files and move them to the "allowed" files, but as @gaearon mentioned, we should remove them as part of the create command (or you can delete before the allowed files check).

[mg]

This is where I am currently.

create-react-app fails, cleans up, but leaves the yarn log file behind. Then it console logs "Done" as expected, but then some script cra.sh complains loudly. Any pointers to what this might be about? The next line after console.log('Done') is process.exit(1);.

info No lockfile found.
[1/4] 🔍  Resolving packages...
error An unexpected error occured, please open a bug report with the information provided in "/Users/mg/Projects/opensource/create-react-app/myapp/yarn-error.log".
info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.

Aborting installation.
  yarnpkg add --exact react react-dom /Users/mg/Projects/opensource/create-react-app/packages/react-scripts/react-scripts-1.0.10.tgz has failed.

Deleting generated file... package.json
Done.
++ set +x
cra.sh: ERROR! An error was encountered executing line 83.
Cleaning up.
Exiting with error.

npm ERR! Darwin 16.6.0
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "run" "create-react-app" "myapp"
npm ERR! node v6.9.1
npm ERR! npm  v3.10.8
npm ERR! code ELIFECYCLE
npm ERR! @ create-react-app: `tasks/cra.sh "myapp"`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the @ create-react-app script 'tasks/cra.sh "myapp"'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the  package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     tasks/cra.sh "myapp"
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/mg/Projects/opensource/create-react-app/npm-debug.log

[Timer]

That looks as expected. Can you create a pull request so we can see what you're doing? I can better help then.

[mg]

no prob

#2705

[makansingh]

I am also getting the same error, while creating a new project in react, I have searched but didn't get the proper solution then, I Start from the beginning by following the react step :
https://facebook.github.io/react/docs/installation.html
and update the node and npm.
and more thing please change your app name, sometime it might be create issue.

Now my App is working fine, hope so it worked for you all.

[brandonburkett]

@mg How did you get around the proxy issue? Are you using Nexus?

[chrislaughlin]

Has this issue been resolved? if not I would like to have a go

[gaearon]

There might have been an existing PR, I haven't checked. We need to do a pass at reviewing pending PRs.

[mg]

I had a PR here (#2705) but I haven't touched this since then, so by all means have a go.

[gaearon]

Fixed by #2705 in next branch.