expect.hasAssertions should throw when passed arguments#3526
Merged
cpojer merged 1 commit intojestjs:masterfrom May 11, 2017
Merged
expect.hasAssertions should throw when passed arguments#3526cpojer merged 1 commit intojestjs:masterfrom
cpojer merged 1 commit intojestjs:masterfrom
Conversation
* `expect.hasAssertions()` should not allow useless parameters to limit confusion with `expect.assertions(<n>)`. Fixes jestjs#3517
Codecov Report
@@ Coverage Diff @@
## master #3526 +/- ##
==========================================
+ Coverage 62.25% 62.26% +<.01%
==========================================
Files 181 181
Lines 6706 6707 +1
Branches 6 6
==========================================
+ Hits 4175 4176 +1
Misses 2528 2528
Partials 3 3
Continue to review full report at Codecov.
|
thymikee
reviewed
May 10, 2017
| it('throws if passed parameters', () => { | ||
| jestExpect(() => { | ||
| jestExpect.hasAssertions(2); | ||
| }).toThrow(); |
Contributor
There was a problem hiding this comment.
Can you use .toThrowError(/an error message/)? It would be nice to know what do we throw 🙂
tushardhole
pushed a commit
to tushardhole/jest
that referenced
this pull request
Aug 21, 2017
* `expect.hasAssertions()` should not allow useless parameters to limit confusion with `expect.assertions(<n>)`. Fixes jestjs#3517
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
expect.hasAssertions()should not allow useless parameters to limit confusion withexpect.assertions(<n>).Fixes #3517
Summary
expect.hasAssertionsnow throws an exception when is passed parameters which clarifies its difference from the similar matcher,expect.assertions(<n>).Test plan
yarn test