Refactor names and delimiters of complex values in pretty-format

[pedrottimark]

Summary

There are some inconsistencies in names of complex types for various options:

• specific case for empty list is Arguments [] but general case with min: true is []
• specific case for empty array is Array [] and so on, but general case with min: true is []
• when hitMaxDepth for typed array is [Array] instead of [Uint32Array] and so on
• when hitMaxDepth for constructed object is [Object] instead of '[' + (val.constructor ? val.constructor.name : 'Object') + ']' and I’m not sure tests cover this case

If y’all are willing to approve breaking changes to edge cases, I can submit an additional PR.

Whether or not, this PR applies advice from Kent Beck: move similar elements closer together.

• Move empty arguments and array from printBasicValue to printComplexValue
• Move complex value name and delimiters from helpers to printComplexValue
• Therefore delete redundant helpers printArguments and printArray

Effect of refactoring on performance:

• Time to print empty arguments or array increases similar to empty object. I think the reason for the original logic is to avoid computing indent when it isn’t used for those values. It has been confusing to me that the special cases in printBasicValue (where I don’t expect to find arguments or arrays) are inconsistent with the general cases in printCompexValue :(
• Time saving from evaluating isToStringedArrayType only 1 time instead of 2 and calling printList directly for arguments and array is subtle, within the precision of measurement.

Test plan

Jest

[cpojer]

Seems like circle is unhappy.

[pedrottimark]

In case it helps, I will push another commit to fix this unrelated problem:

$ eslint . --cache --ext js,md

/Users/mark/gitforks/jest/packages/jest-haste-map/src/index.js
  831:1  error  Delete `······`  prettier/prettier

✖ 1 problem (1 error, 0 warnings)
  1 error, 0 warnings potentially fixable with the `--fix` option.

error Command failed with exit code 1.

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@e6704bf). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #3986   +/-   ##
=========================================
  Coverage          ?   59.97%           
=========================================
  Files             ?      196           
  Lines             ?     6814           
  Branches          ?        6           
=========================================
  Hits              ?     4087           
  Misses            ?     2724           
  Partials          ?        3

Impacted Files	Coverage Δ
packages/jest-haste-map/src/index.js	92.96% <ø> (ø)
packages/pretty-format/src/index.js	97.98% <100%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6704bf...43a4664. Read the comment docs.

[cpojer]

Happy to accept a PR for breaking changes when you are making edge cases more consistent.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.