--showConfig change to show all config, jest-editor-support fails#4494
--showConfig change to show all config, jest-editor-support fails#4494cpojer merged 6 commits intojestjs:masterfrom recca0120:master
Conversation
|
I would like to see this fix too. Looks like just a simple lint/whitespace issue, @recca0120, can you fix it so the test can pass. thx. |
Codecov Report
@@ Coverage Diff @@
## master #4494 +/- ##
==========================================
+ Coverage 56.85% 56.87% +0.02%
==========================================
Files 186 186
Lines 6300 6303 +3
Branches 3 3
==========================================
+ Hits 3582 3585 +3
Misses 2717 2717
Partials 1 1
Continue to review full report at Codecov.
|
|
@connectdotz done |
|
cc @orta pls review |
|
Yep - this looks 👍 @recca0120 |
|
@recca0120, @orta, I haven't really tested this, but looking at the code further, it strikes me that the change might break the older jest version which still output |
|
Hrm, yeah, that's a good point - this would only support Jest 21. I missed this, at this point we don't know what version of Jest someone is running. Could we possibly check the response and support both? |
|
That sounds right, if |
|
yes, I'll send PR to fix it laster |
…stjs#4494) * --showConfig to show all project configs jestjs#4078 * return configs * new method getConfigs * new method getConfigs * call completed * eslint
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
6 participants
Summary
jest 21.0.0
--showConfig flag will return configs