Add babel-plugin for object spread syntax to babel-preset-jest

[SimenB]

Summary
Seems like the easiest fix to #4248.

(typos in the commit message are the best)

Test plan
Running this version makes tests using object spread on node 8 pass without manually including the babel plugin there. Note that this doesn't transpile the syntax, it only allows babel to parse it.
Not sure if a test in this repo makes sense as it already gets that syntax plugin transitively in its own .babelrc

[thymikee]

LGTM 👍

[cpojer]

Makes sense!

[digitalkaoz]

@cpojer @SimenB object rest spread works fine during tests, but it fails again if i run jest with coverage

jest --coverage

[SimenB]

@digitalkaoz that's probably because the istanbul instrumentation is outdated on your end. What does npm ls istanbul-lib-instrument say? You Need istanbul-lib-instrument@1.8.0.

istanbuljs/istanbuljs#82

[digitalkaoz]

@SimenB it seems i have 1.8.0

[root@d3e9f6900b3f app]# npm -g ls istanbul-lib-instrument
/usr/lib
└─┬ jest@21.2.1
  └─┬ jest-cli@21.2.1
    ├─┬ istanbul-api@1.1.14
    │ └── istanbul-lib-instrument@1.8.0  deduped
    ├── istanbul-lib-instrument@1.8.0
    └─┬ jest-runtime@21.2.1
      └─┬ babel-plugin-istanbul@4.1.5
        └── istanbul-lib-instrument@1.8.0  deduped

[SimenB]

Hmm, that's odd. What error are you getting?

[digitalkaoz]

/var/app/source.js: Unexpected token (29:37)
      > 29 |                 foo[name].options = {...globalConfig, ...foo[name].options};
           |                                      ^
        30 |             }
        31 |         });
        32 | 

[SimenB]

I can't reproduce on my machine.

index.js

const obj = {
    foo: 'bar'
};

module.exports = {
    ...obj,
    foobar: 'baz'
};

test.js:

const file = require('./');

test('something', () => {
    expect(file).toEqual({
        foo: 'bar',
        foobar: 'baz'
    });
});

$ yarn jest --coverage
 PASS  ./test.js
  ✓ something (3ms)

Test Suites: 1 passed, 1 total
Tests:       1 passed, 1 total
Snapshots:   0 total
Time:        0.787s, estimated 1s
Ran all test suites.
----------|----------|----------|----------|----------|----------------|
File      |  % Stmts | % Branch |  % Funcs |  % Lines |Uncovered Lines |
----------|----------|----------|----------|----------|----------------|
All files |      100 |      100 |      100 |      100 |                |
 index.js |      100 |      100 |      100 |      100 |                |
----------|----------|----------|----------|----------|----------------|

On node 8.6.0

[digitalkaoz]

mh same setup here, gives me:

[root@d3e9f6900b3f tmp]# jest .
 PASS  ./test.js
  ✓ something (6ms)

Test Suites: 1 passed, 1 total
Tests:       1 passed, 1 total
Snapshots:   0 total
Time:        0.847s
Ran all test suites matching /./i.

[root@d3e9f6900b3f tmp]# jest --coverage
 FAIL  ./test.js
  ● Test suite failed to run

    /tmp/index.js: Unexpected token (6:4)
        4 |
        5 | module.exports = {
      > 6 |     ...obj,
          |     ^
        7 |     foobar: 'baz'
        8 | };
        9 |

Test Suites: 1 failed, 1 total
Tests:       0 total
Snapshots:   0 total
Time:        1.105s
Ran all test suites.
----------|----------|----------|----------|----------|----------------|
File      |  % Stmts | % Branch |  % Funcs |  % Lines |Uncovered Lines |
----------|----------|----------|----------|----------|----------------|
All files |  Unknown |  Unknown |  Unknown |  Unknown |                |
----------|----------|----------|----------|----------|----------------|

[root@d3e9f6900b3f tmp]# node --version
v8.6.0
[root@d3e9f6900b3f tmp]# npm --version
5.4.2
[root@d3e9f6900b3f tmp]# npm -g ls jest
/usr/lib
└── jest@21.2.1

[root@d3e9f6900b3f tmp]# npm -g ls istanbul-lib-instrument
/usr/lib
└─┬ jest@21.2.1
  └─┬ jest-cli@21.2.1
    ├─┬ istanbul-api@1.1.14
    │ └── istanbul-lib-instrument@1.8.0  deduped
    ├── istanbul-lib-instrument@1.8.0
    └─┬ jest-runtime@21.2.1
      └─┬ babel-plugin-istanbul@4.1.5
        └── istanbul-lib-instrument@1.8.0  deduped

[digitalkaoz]

mh if i install jest locally, it works...

[root@d3e9f6900b3f tmp]# npm ls istanbul-lib-instrument
/tmp
└─┬ jest@21.2.1
  └─┬ jest-cli@21.2.1
    ├─┬ istanbul-api@1.1.14
    │ └── istanbul-lib-instrument@1.8.0  deduped
    ├── istanbul-lib-instrument@1.8.0
    └─┬ jest-runtime@21.2.1
      └─┬ babel-plugin-istanbul@4.1.5
        └── istanbul-lib-instrument@1.8.0  deduped

@SimenB any idea on this?

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

[digitalkaoz]

mh same setup here, gives me:

[root@d3e9f6900b3f tmp]# jest .
 PASS  ./test.js
  ✓ something (6ms)

Test Suites: 1 passed, 1 total
Tests:       1 passed, 1 total
Snapshots:   0 total
Time:        0.847s
Ran all test suites matching /./i.

[root@d3e9f6900b3f tmp]# jest --coverage
 FAIL  ./test.js
  ● Test suite failed to run

    /tmp/index.js: Unexpected token (6:4)
        4 |
        5 | module.exports = {
      > 6 |     ...obj,
          |     ^
        7 |     foobar: 'baz'
        8 | };
        9 |

Test Suites: 1 failed, 1 total
Tests:       0 total
Snapshots:   0 total
Time:        1.105s
Ran all test suites.
----------|----------|----------|----------|----------|----------------|
File      |  % Stmts | % Branch |  % Funcs |  % Lines |Uncovered Lines |
----------|----------|----------|----------|----------|----------------|
All files |  Unknown |  Unknown |  Unknown |  Unknown |                |
----------|----------|----------|----------|----------|----------------|

[root@d3e9f6900b3f tmp]# node --version
v8.6.0
[root@d3e9f6900b3f tmp]# npm --version
5.4.2
[root@d3e9f6900b3f tmp]# npm -g ls jest
/usr/lib
└── jest@21.2.1

[root@d3e9f6900b3f tmp]# npm -g ls istanbul-lib-instrument
/usr/lib
└─┬ jest@21.2.1
  └─┬ jest-cli@21.2.1
    ├─┬ istanbul-api@1.1.14
    │ └── istanbul-lib-instrument@1.8.0  deduped
    ├── istanbul-lib-instrument@1.8.0
    └─┬ jest-runtime@21.2.1
      └─┬ babel-plugin-istanbul@4.1.5
        └── istanbul-lib-instrument@1.8.0  deduped

[digitalkaoz]

mh if i install jest locally, it works...

[root@d3e9f6900b3f tmp]# npm ls istanbul-lib-instrument
/tmp
└─┬ jest@21.2.1
  └─┬ jest-cli@21.2.1
    ├─┬ istanbul-api@1.1.14
    │ └── istanbul-lib-instrument@1.8.0  deduped
    ├── istanbul-lib-instrument@1.8.0
    └─┬ jest-runtime@21.2.1
      └─┬ babel-plugin-istanbul@4.1.5
        └── istanbul-lib-instrument@1.8.0  deduped

@SimenB any idea on this?

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.