Add simple rAF polyfill in jsdom environment by SimenB · Pull Request #4568 · jestjs/jest

SimenB · 2017-09-30T09:01:10Z

Summary
Closes #4545

Test plan
Added integration test copied from setImmediate

SimenB · 2017-09-30T09:17:56Z

No idea why it fails on windows. Anyone?

cpojer · 2017-09-30T09:30:08Z

I'm assuming it fails because we don't wait for the setTimeout, which is async, to complete, and the event loop has a different behavior on Windows

SimenB · 2017-09-30T09:43:37Z

Ok, tried a new approach for the test

SimenB · 2017-09-30T09:46:13Z

We should also keep an eye on jsdom/jsdom#1963 so that we can potentially revert this change again in the future

SimenB · 2017-09-30T10:48:33Z

Hmm, new test didn't help. I don't have a windows box available either. Ideas? Skipping it on windows seems like the wrong solution

cpojer · 2017-09-30T18:20:07Z

As said, I suspect the event loop works slightly differently on Windows. Since you are implementing it using setTimeout, you can use jest.useFakeTimers() and then use jest.runAllTimers() after scheduling the rAF call, and it should be called synchronously and make the test fail also on Windows.

If that doesn't work, I'm ok sipping it so we can merge it.

SimenB · 2017-09-30T19:56:47Z

Hmm, after logging out stderr from the test run on appveyor, it seems that raf is not available.

 FAIL __tests__\request_animation_frame.test.js
        × requestAnimationFrame test
      
        ● requestAnimationFrame test
      
          ReferenceError: requestAnimationFrame is not defined
            
            at Object.<anonymous>.done (__tests__/request_animation_frame.test.js:15:3)
                at Promise (<anonymous>)
                at <anonymous>
      
        ● requestAnimationFrame test
      
          expect.hasAssertions()
          
          Expected at least one assertion to be called but received none.
            
            at extractExpectedAssertionsErrors (../../node_modules/expect/build/extract_expected_assertions_errors.js:64:19)
                at <anonymous>
      
      Test Suites: 1 failed, 1 total
      Tests:       1 failed, 1 total
      Snapshots:   0 total
      Time:        1.109s
      Ran all test suites.

Not sure how that happens. I'll see if I'm able to start up a virtual machine and install git, node and yarn to test

SimenB · 2017-09-30T20:07:57Z

I'm confused, the test passes on a Windows 7 image...

SimenB · 2017-09-30T20:19:44Z

Well, upgrading to yarn 1.1.0 made appveyor green 🤷‍♂️

This reverts commit 08d58c5.

codecov-io · 2017-09-30T20:22:40Z

Codecov Report

Merging #4568 into master will increase coverage by 0.43%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #4568      +/-   ##
=========================================
+ Coverage   55.66%   56.1%   +0.43%     
=========================================
  Files         186     185       -1     
  Lines        6345    6292      -53     
  Branches        3       3              
=========================================
- Hits         3532    3530       -2     
+ Misses       2812    2761      -51     
  Partials        1       1

Impacted Files	Coverage Δ
packages/jest-environment-jsdom/src/index.js	`0% <0%> (ø)`	⬆️
.../jest-editor-support/src/parsers/babylon_parser.js	`98.57% <0%> (-0.04%)`	⬇️
packages/jest-editor-support/src/index.js	`0% <0%> (ø)`	⬆️
packages/jest-editor-support/src/Snapshot.js

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfe1a9a...4968028. Read the comment docs.

SimenB · 2017-09-30T20:26:06Z

+        const hrInNano = hr[0] * 1e9 + hr[1];
+        const hrInMicro = hrInNano / 1e6;
+
+        return global.setTimeout(callback, 0, hrInMicro);


I'm currently working on getting it upstreamed into JSDOM, so I read some of the spec. I don't know if people use this argument, or expect it to be in any way accurate, but this is a best effort 🙂

SimenB · 2017-09-30T20:28:34Z

  moduleMocker: ?ModuleMocker;

  constructor(config: ProjectConfig): void {
+    const jsdomInitialized = process.hrtime();


I'd prefer to have it beneath the JSDom.jsdom call, but that makes stuff fail with an odd flow error...

* Add simple rAF polyfill in jsdom environment Closes jestjs#4545 * Fix flow error * Tweak test * Try to log out stderr on CI * Use snake case naming for test file * Update to newest yarn on ci * Revert "Try to log out stderr on CI" This reverts commit 08d58c5. * Remove extra -- from appveyor to avoid warning on newer yarn * Include time since window initialised in rAF implementation

hjylewis · 2017-10-13T20:11:13Z

When will this be released?

SimenB · 2017-10-13T20:45:56Z

It is out in 21.3.0-beta.2

github-actions · 2021-05-13T04:09:43Z

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

Add simple rAF polyfill in jsdom environment

3c6b120

Closes jestjs#4545

facebook-github-bot added the CLA Signed ✔️ label Sep 30, 2017

Fix flow error

617562d

Tweak test

484c26d

Try to log out stderr on CI

08d58c5

SimenB added 2 commits September 30, 2017 22:10

Use snake case naming for test file

23dd2bc

Update to newest yarn on ci

7c91e67

SimenB added 2 commits September 30, 2017 22:20

Revert "Try to log out stderr on CI"

78b5ebf

This reverts commit 08d58c5.

Remove extra -- from appveyor to avoid warning on newer yarn

b3f85a2

SimenB commented Sep 30, 2017

View reviewed changes

Include time since window initialised in rAF implementation

4968028

SimenB force-pushed the raf branch from 9abbe75 to 4968028 Compare September 30, 2017 20:27

SimenB commented Sep 30, 2017

View reviewed changes

cpojer merged commit 216e8ed into jestjs:master Sep 30, 2017

SimenB deleted the raf branch September 30, 2017 20:49

kwelch mentioned this pull request Oct 1, 2017

React 16 coryhouse/react-slingshot#480

Merged

gaearon mentioned this pull request Oct 28, 2017

Consider adding cancelAnimationFrame polyfill #4779

Closed

mAiNiNfEcTiOn mentioned this pull request Nov 15, 2017

Updates to React 16 Travix-International/travix-ui-kit#231

Merged

renovate-tests mentioned this pull request Feb 6, 2018

Update dependency jest to v22 - autoclosed renovate-tests/changelog-md#3

Closed

renovate Bot mentioned this pull request Feb 14, 2018

fix(deps): update dependency jest to ^22.0.0 manekinekko/devoxx-assistant#3

Open

Robdel12 mentioned this pull request Oct 31, 2018

React 16 + Ref Support percy/react-percy#106

Merged

github-actions Bot locked as resolved and limited conversation to collaborators May 13, 2021

Uh oh!

Conversation

SimenB commented Sep 30, 2017

Uh oh!

SimenB commented Sep 30, 2017

Uh oh!

cpojer commented Sep 30, 2017

Uh oh!

SimenB commented Sep 30, 2017

Uh oh!

SimenB commented Sep 30, 2017

Uh oh!

SimenB commented Sep 30, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cpojer commented Sep 30, 2017

Uh oh!

SimenB commented Sep 30, 2017

Uh oh!

SimenB commented Sep 30, 2017

Uh oh!

SimenB commented Sep 30, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-io commented Sep 30, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

SimenB Sep 30, 2017

Choose a reason for hiding this comment

Uh oh!

SimenB Sep 30, 2017

Choose a reason for hiding this comment

Uh oh!

hjylewis commented Oct 13, 2017

Uh oh!

SimenB commented Oct 13, 2017

Uh oh!

github-actions Bot commented May 13, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

SimenB commented Sep 30, 2017 •

edited

Loading

SimenB commented Sep 30, 2017 •

edited

Loading

codecov-io commented Sep 30, 2017 •

edited

Loading