Fix asynchronous test will fail due to timeout issue.

[H1Gdev]

• Send error event to Node.js process.

Summary

Execute following asynchronous test.

it('asynchronous test', (done) => {
  setTimeout(function() {
    expect(false).toBeTruthy();
    done();
  }, 1 * 1000);
});

Expect:

    expect(received).toBeTruthy()

    Expected value to be truthy, instead received
      false

Actual:

Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.

Test plan

Above test result as expected.

  ● describe ? asynchronous test

    expect(received).toBeTruthy()

    Expected value to be truthy, instead received
      false

      at __tests__/test.spec.js:23:21
      at Timeout.callback [as _onTimeout] (node_modules/jsdom/lib/jsdom/browser/Window.js:523:19)
      at ontimeout (timers.js:365:14)
      at tryOnTimeout (timers.js:237:5)
      at Timer.listOnTimeout (timers.js:207:5)

[SimenB]

I don't understand how this i happening but I can confirm both the issue, and the fact that this diff fixes it. Thanks!

[SimenB]

This needs an integration test

[H1Gdev]

@SimenB
Thank you for your review.

When throw exception in callback function, jsdom window catches and send error event.(like web browser)

So in this PR receive error event from jsdom and send error event to Node.js process.

[SimenB]

Cool, thanks for the explanation!

Adding an integration test for this should be pretty simple, just assert on stdout that it contains e.g. Expected value to be truthy, instead received

[SimenB]

Thanks!

I updated the test you wrote to actually run in jsdom (it passed without your changes as well, as it ran in node environment).

[SimenB]

Right now there is no way to assert what testEnvironment a test is run in. But I doubt someone will change this anyways, so shouldn't be a problem

[cpojer]

This is a nice fix, thank you for sending a PR.

[SimenB]

@H1Gdev would you mind sending a PR adding a line to the changelog about this? 🙂

[H1Gdev]

@SimenB
Yes of course.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.