Upgrade jsdom to 11.4 #4919
Merged
Upgrade jsdom to 11.4 #4919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4919 +/- ##
==========================================
+ Coverage 59.98% 60.01% +0.02%
==========================================
Files 198 198
Lines 6563 6555 -8
Branches 4 4
==========================================
- Hits 3937 3934 -3
+ Misses 2626 2621 -5
Continue to review full report at Codecov.
|
thymikee
approved these changes
Nov 20, 2017
Member
|
Nice work @SimenB, so happy you pushed on this. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This updates JSDOM to a version which includes support for
{request,cancel}AnimationFrameout of the box.Test plan
I verified that the deleted test worked with the new code before deleting it.