Fix errors when identity-obj-proxy mocks CSS Modules#4935
Fix errors when identity-obj-proxy mocks CSS Modules#4935cpojer merged 2 commits intojestjs:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4935 +/- ##
==========================================
+ Coverage 60.26% 60.27% +0.01%
==========================================
Files 198 198
Lines 6593 6595 +2
Branches 3 3
==========================================
+ Hits 3973 3975 +2
Misses 2620 2620
Continue to review full report at Codecov.
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Fixes #4580 and #4922
Because the mock identity object for CSS Modules returns the key as the value for any key:
trueavoids false positive inImmutableplugintestmethodval.constructor === 'function'avoids undefined as name of objectSee Mocking CSS Modules
Test plan
Added 2 tests which failed before changes to code, and then fixed them to fail for right reason :)