Add "debug" method to console #5350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
reviewed
Jan 19, 2018
Contributor
thymikee
left a comment
thymikee
left a comment
There was a problem hiding this comment.
How about null_console when --silent is passed? https://github.com/facebook/jest/blob/master/packages/jest-util/src/null_console.js
Contributor
Author
|
I'm not sure about the CI errors... |
Contributor
Author
|
@thymikee thanks for the heads up; I knew there were three but couldn't remember the name. I also fixed it 🙂 |
thymikee
approved these changes
Jan 19, 2018
Contributor
|
CircleCI is having some weird issues lately... |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
consoleglobal is overridden with a custom implementation in order to be able to buffer it per test. However, the "debug" method is missing in either of the implementations (CustomConsoleandBufferedConsole), so when doingconsole.debugyou end up calling the real implementation.This causes troubles, and especially when using the
jsdomenvironment, where an extra indirection layer is added viaVirtualConsole, which re-wraps methods once again.