fix: get builtin modules from node core#5411
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5411 +/- ##
==========================================
- Coverage 62.26% 61.36% -0.91%
==========================================
Files 205 205
Lines 6925 6926 +1
Branches 4 3 -1
==========================================
- Hits 4312 4250 -62
- Misses 2612 2675 +63
Partials 1 1
Continue to review full report at Codecov.
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
We don't currently get the list of builtins from node core, as we use the wrong API. See https://nodejs.org/api/modules.html#modules_module_builtinmodules
Test plan
Tested using
console.loglocally on node 9.4.0 that the list exists.