Skip to content

Conversation

@mattphillips
Copy link
Contributor

@mattphillips mattphillips commented Mar 21, 2018

Summary

  • Remove incorrect 22.4 docs
  • Regenerate v22.4 docs at 22.4.2 release commit (83a51cc)

Fixes #5849 and #5848

Note

This will remove any doc changes that happened after that release including: jest-community page and a few fixes until we do the next release.

I'm happy to send another PR once this is merged that cherry picks backwards compatible doc changes in master. I think it will be too hard to review those changes as part of this so makes sense in another PR.

@mattphillips mattphillips changed the title Website fix Fix website docs Mar 21, 2018
@SimenB
Copy link
Member

SimenB commented Mar 21, 2018

Why remove 22.3?

@mattphillips
Copy link
Contributor Author

mattphillips commented Mar 21, 2018

@SimenB for some reason I thought you mentioned deleting it in my last PR - I just checked and I misread 😆

I'll push a change now to put it back!

@@ -1,336 +0,0 @@
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be removed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it should

# Conflicts:
#	CHANGELOG.md
#	website/versioned_docs/version-22.4/ExpectAPI.md
#	website/versioned_docs/version-22.4/MockFunctionAPI.md
#	website/versioned_docs/version-22.4/MockFunctions.md
Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I resolved the conflicts, verified this is all correct, and tested locally 👌

@codecov-io
Copy link

Codecov Report

Merging #5853 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5853   +/-   ##
=======================================
  Coverage   64.13%   64.13%           
=======================================
  Files         217      217           
  Lines        8335     8335           
  Branches        3        3           
=======================================
  Hits         5346     5346           
  Misses       2988     2988           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 558416f...0557bd2. Read the comment docs.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

expect.not.arrayContaining not working

5 participants