set default display name color based on runner #8689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeysal
force-pushed
the
displayname-default-color
branch
from
3bb8607 to
651a802
Compare
SimenB
approved these changes
Jul 15, 2019
Member
SimenB
left a comment
SimenB
left a comment
There was a problem hiding this comment.
Missing changelog, but code lgtm
rogeliog
reviewed
Jul 15, 2019
jeysal
force-pushed
the
displayname-default-color
branch
from
651a802 to
17e55ac
Compare
Collaborator
Author
|
Incorporated review feedback. Intentionally didn't add changelog yet, will do so once we can actually land breaking changes :) |
rogeliog
approved these changes
Aug 12, 2019
Member
|
@jeysal mind rebasing on the |
jeysal
force-pushed
the
displayname-default-color
branch
from
17e55ac to
6faff95
Compare
Collaborator
Author
|
@SimenB done :) should be good to go I think, manually tested it again |
BREAKING CHANGE: changes the internal config format for certain user-provided configs
SimenB
force-pushed
the
displayname-default-color
branch
from
6faff95 to
3adab48
Compare
This was referenced Jan 28, 2020
This was referenced Feb 4, 2020
This was referenced Feb 11, 2020
This was referenced Feb 25, 2020
This was referenced Mar 3, 2020
This was referenced Mar 10, 2020
This was referenced Mar 24, 2020
This was referenced Apr 16, 2020
This was referenced Apr 30, 2020
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up to @natealcedo's #8025, automatically generating reasonable defaults for that feature.
BREAKING CHANGE:
See comment that was removed. Looks like it'll have to wait until 25 :|
TODO add changelog when there's a section to put it in without having to rebase ;)
Test plan
Added normalize tests. Tried on work project, tests are white, lints are green :)