Skip to content

Commit 0199a03

Browse files
mdvaccafacebook-github-bot
authored andcommitted
Revisit deprecated methods in UIManagerModule and update javadoc
Summary: Ez diff that revisits deprecated methods in UIManagerModule and update javadoc Motivation: I'm cleaning up my fabric backlog before lockdown changelog: [Android] Update documentation of UIManagerModule methods Reviewed By: JoshuaGross Differential Revision: D21487609 fbshipit-source-id: 896ae21e02d5b1aa57b7158d714986fd1f8c9c5c
1 parent d0c4c5e commit 0199a03

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

ReactAndroid/src/main/java/com/facebook/react/uimanager/UIManagerModule.java

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -283,7 +283,8 @@ private static Map<String, Object> createConstants(
283283
* Helper method to pre-compute the constants for a view manager. This method ensures that we
284284
* don't block for getting the constants for view managers during TTI
285285
*
286-
* @param viewManagerNames
286+
* @deprecated this method will not be available in FabricUIManager class.
287+
* @param viewManagerNames {@link List<String>} names of ViewManagers
287288
*/
288289
@Deprecated
289290
public void preComputeConstantsForViewManager(List<String> viewManagerNames) {
@@ -568,7 +569,7 @@ public void setChildren(int viewTag, ReadableArray childrenTags) {
568569
* This resolves to a simple {@link #manageChildren} call, but React doesn't have enough info in
569570
* JS to formulate it itself.
570571
*
571-
* @deprecated This method will not be available in Fabric UIManager.
572+
* @deprecated This method will not be available in Fabric UIManager class.
572573
*/
573574
@ReactMethod
574575
@Deprecated
@@ -578,10 +579,10 @@ public void replaceExistingNonRootView(int oldTag, int newTag) {
578579

579580
/**
580581
* Method which takes a container tag and then releases all subviews for that container upon
581-
* receipt. TODO: The method name is incorrect and will be renamed, #6033872
582+
* receipt.
582583
*
583584
* @param containerTag the tag of the container for which the subviews must be removed
584-
* @deprecated This method will not be available in Fabric UIManager.
585+
* @deprecated This method will not be available in Fabric UIManager class.
585586
*/
586587
@ReactMethod
587588
@Deprecated
@@ -631,7 +632,7 @@ public void measureLayout(
631632
* window which can cause unexpected results when measuring relative to things like ScrollViews
632633
* that can have offset content on the screen.
633634
*
634-
* @deprecated This method will not be part of Fabric.
635+
* @deprecated this method will not be available in FabricUIManager class.
635636
*/
636637
@ReactMethod
637638
@Deprecated
@@ -664,7 +665,7 @@ public void findSubviewIn(
664665
/**
665666
* Check if the first shadow node is the descendant of the second shadow node
666667
*
667-
* @deprecated This method will not be part of Fabric.
668+
* @deprecated this method will not be available in FabricUIManager class.
668669
*/
669670
@ReactMethod
670671
@Deprecated

0 commit comments

Comments
 (0)