Proper attributed strings comparsion in RCTBaseTextInputView

shergin · facebook-github-bot · commit 46fd8643485b · 2018-01-25T13:47:35.000-08:00
Summary:
Now, in the new model, we transfer text attributes with actual text via attributed text to a native text component,
so previous text-only comparsion is not sufficient anymore.

Depends on D6600685.

Differential Revision: D6809833

fbshipit-source-id: 475b7426cf3c6694781790d99ef32466606da2f2
diff --git a/Libraries/Text/TextInput/RCTBaseTextInputView.m b/Libraries/Text/TextInput/RCTBaseTextInputView.m
@@ -102,7 +102,7 @@ - (void)setAttributedText:(NSAttributedString *)attributedText
 {
   NSInteger eventLag = _nativeEventCount - _mostRecentEventCount;
 
-  if (eventLag == 0 && ![attributedText.string isEqualToString:self.backedTextInputView.attributedText.string]) {
+  if (eventLag == 0 && ![attributedText isEqualToAttributedString:self.backedTextInputView.attributedText]) {
     UITextRange *selection = self.backedTextInputView.selectedTextRange;
     NSInteger oldTextLength = self.backedTextInputView.attributedText.string.length;
 

Original file line number	Diff line number	Diff line change
`@@ -102,7 +102,7 @@ - (void)setAttributedText:(NSAttributedString *)attributedText`
`102`	`102`	`{`
`103`	`103`	`NSInteger eventLag = _nativeEventCount - _mostRecentEventCount;`
`104`	`104`
`105`		`- if (eventLag == 0 && ![attributedText.string isEqualToString:self.backedTextInputView.attributedText.string]) {`
	`105`	`+ if (eventLag == 0 && ![attributedText isEqualToAttributedString:self.backedTextInputView.attributedText]) {`
`106`	`106`	`UITextRange *selection = self.backedTextInputView.selectedTextRange;`
`107`	`107`	`NSInteger oldTextLength = self.backedTextInputView.attributedText.string.length;`
`108`	`108`