Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: facebook/react
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2c3f7058604ac63495bb81a5c14d812be4b6569c
Choose a base ref
...
head repository: facebook/react
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 09a7a6af246dd6f553d15dde91ba14f13e92e9ae
Choose a head ref
  • 3 commits
  • 8 files changed
  • 2 contributors

Commits on Sep 10, 2024

  1. [DevTools] Implement getComponentStack and onErrorOrWarning for repla… 

    …yed Flight logs (#30930)

This adds owner stacks to replayed Server Component logs in environments
that don't support native console.createTask.

<img width="521" alt="Screenshot 2024-09-09 at 8 55 21 PM"
src="https://github.com/user-attachments/assets/261cfaee-ea65-4044-abf0-c41abf358fea">

It also tracks the logs in the global componentInfoToComponentLogsMap
which lets us associate those logs with Server Components when they
later commit into the fiber tree.

<img width="1280" alt="Screenshot 2024-09-09 at 9 31 16 PM"
src="https://github.com/user-attachments/assets/436312a6-f9f4-4add-8129-0fb9b9eb18ee">

I tried to create unit tests for this since it's now wired up
end-to-end. Unfortunately, the complicated testing set up for Flight
requires a complex set of resetting modules which are incompatible with
the complicated test setup in getVersionedRenderImplementation for
DevTools tests.
    @sebmarkbage
    sebmarkbage authored Sep 10, 2024
    Configuration menu
    Copy the full SHA
    63cefa2 View commit details
    Browse the repository at this point in the history

  2. refactor[RendererInterface]: expose onErrorOrWarning and getComponent… 

    …Stack (#30931)

Make `onErrorOrWarning` and `getComponentStack` part of
`rendererInterface`. By doing this, they will be available from the
global hook `rendererInterfaces` Map. This makes them available to be
used by Hook, which soon will be the only one who is doing console
patching.

This is also a pre-requisite for removing `registerRenderer`:

https://github.com/facebook/react/blob/d160aa0fbb1bd2d00ea8c771c551c9cb5b47f1e9/packages/react-devtools-shared/src/backend/console.js#L113-L121
    @hoxyq
    hoxyq authored Sep 10, 2024
    Configuration menu
    Copy the full SHA
    3dfd5d9 View commit details
    Browse the repository at this point in the history

  3. feat[react-devtools]: add settings to global hook object

    @hoxyq
    hoxyq committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    09a7a6a View commit details
    Browse the repository at this point in the history
Loading