Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: facebook/react
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 8b2d3783e58d1acea53428a10d2035a8399060fe
Choose a base ref
...
head repository: facebook/react
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: fbb03753b0edcb1b5df81cd3de077eaa655a5a61
Choose a head ref
  • 2 commits
  • 4 files changed
  • 2 contributors

Commits on Sep 18, 2020

  1. Don't call onCommit et al if there are no effects

    Checks `subtreeFlags` before scheduling an effect on the Profiler.
    acdlite committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    df96450 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2020

  1. Fix failing Profiler tests

    The change to conditionally call Profiler commit hooks only if updates were scheduled broke a few of the Profiler tests. I've fixed the tests by either:
    * Adding a no-op passive effect into the subtree or
    * Converting onPostCommit to onCommit
    
    When possible, I opted to add the no-op passive effect to the tests since that that hook is called later (during passive phase) so the test is a little broader. In a few cases, this required adding awkward act() wrappers so I opted to go with onCommit instead.
    Brian Vaughn committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    fbb0375 View commit details
    Browse the repository at this point in the history
Loading