Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: facebook/react
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: c4cac627b3538fd6abc4c393baf94454e7479e12
Choose a base ref
...
head repository: facebook/react
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: f7abc4ab5ce4a07d286987cff29dbc9eb6cd2b54
Choose a head ref
  • 1 commit
  • 5 files changed
  • 1 contributor

Commits on Aug 20, 2024

  1. [Flight] When halting omit any reference rather than refer to a share… 

    …d missing chunk

When aborting a prerender we should leave references unfulfilled, not share a common unfullfilled reference. functionally today this doesn't matter because we don't have resuming but the semantic is that the row was not available when the abort happened and in a resume the row should fill in. But by pointing each task to a common unfulfilled chunk we lose the ability for these references to resolves to distinct values on resume.

There are edge cases though like if we're aborting while rendering and we have a model that needs to refer to some reference that we don't know the identity of
    @gnoff
    gnoff committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    f7abc4a View commit details
    Browse the repository at this point in the history
Loading