From 607e68f73c40b34a3e2a2d7336056a6586b1ffd0 Mon Sep 17 00:00:00 2001 From: Yunchan Cho Date: Sat, 8 Sep 2018 11:39:32 +0900 Subject: [PATCH] Remove redundant work during mounting Indeterminate Component During mounting Indeterminate Component, it's redundant to check and call getDerivedStateFromProps method. Because getDerivedStateFromProps method will be called by mountClassInstance right after changing the fiber's tag to Class Component. --- packages/react-reconciler/src/ReactFiberBeginWork.js | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/packages/react-reconciler/src/ReactFiberBeginWork.js b/packages/react-reconciler/src/ReactFiberBeginWork.js index 48ab7bb0480..4f310ae21df 100644 --- a/packages/react-reconciler/src/ReactFiberBeginWork.js +++ b/packages/react-reconciler/src/ReactFiberBeginWork.js @@ -57,7 +57,6 @@ import warningWithoutStack from 'shared/warningWithoutStack'; import * as ReactCurrentFiber from './ReactCurrentFiber'; import {cancelWorkTimer} from './ReactDebugFiberPerf'; -import {applyDerivedStateFromProps} from './ReactFiberClassComponent'; import { mountChildFibers, reconcileChildFibers, @@ -735,16 +734,6 @@ function mountIndeterminateComponent( workInProgress.memoizedState = value.state !== null && value.state !== undefined ? value.state : null; - const getDerivedStateFromProps = Component.getDerivedStateFromProps; - if (typeof getDerivedStateFromProps === 'function') { - applyDerivedStateFromProps( - workInProgress, - Component, - getDerivedStateFromProps, - props, - ); - } - adoptClassInstance(workInProgress, value); mountClassInstance(workInProgress, Component, props, renderExpirationTime); return finishClassComponent(