Skip to content

[Shallow] Implement setState for Hooks and remount on type change #15120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 15, 2019
Merged

[Shallow] Implement setState for Hooks and remount on type change #15120

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
50f2262
Throw away old shallow renderer state on type change
gaearon Mar 15, 2019
57d2911
Remove _previousComponentIdentity
gaearon Mar 15, 2019
a052618
Use _reset when unmounting
gaearon Mar 15, 2019
8aee192
Use arbitrary componentIdentity
gaearon Mar 15, 2019
4972adb
Support Hook state updates in shallow renderer
gaearon Mar 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use arbitrary componentIdentity 
There was no particular reason it was set to element.type. We just wanted to check if something is a render phase update.
  • Loading branch information
@gaearon
gaearon committed Mar 15, 2019
commit 8aee192e27f37ab2080dc2ba0a177e1ed851cd69
4 changes: 2 additions & 2 deletions packages/react-test-renderer/src/ReactShallowRenderer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -574,7 +574,6 @@ class ReactShallowRenderer {
let shouldRender = true;
if (
isMemo(element.type) &&
elementType === this._previousComponentIdentity &&
previousElement !== null
) {
// This is a Memo component that is being re-rendered.
Expand All @@ -586,7 +585,8 @@ class ReactShallowRenderer {
if (shouldRender) {
const prevDispatcher = ReactCurrentDispatcher.current;
ReactCurrentDispatcher.current = this._dispatcher;
this._prepareToUseHooks(elementType);
const componentIdentity = {};
this._prepareToUseHooks(componentIdentity);
try {
// elementType could still be a ForwardRef if it was
// nested inside Memo.
Expand Down