Skip to content

Update cache() and use() to the canary aka next channel #25502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Oct 24, 2022
Merged

Update cache() and use() to the canary aka next channel #25502

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
ede1487
Enable use, Float, ServerContext, Host Singleton flags
sebmarkbage Oct 17, 2022
e7eb7a0
Expose on "react" entry points
sebmarkbage Oct 17, 2022
c2e97c6
Export preinit and preload on "react-dom"
sebmarkbage Oct 17, 2022
4b820ed
Expose Server Components subset in stable "react"
sebmarkbage Oct 17, 2022
d2cbb58
Publish react-server-dom-webpack to next channel
sebmarkbage Oct 17, 2022
3b2b293
Rename experimental_use to use
sebmarkbage Oct 17, 2022
b224cc9
Fix fixtures
sebmarkbage Oct 18, 2022
d56a955
Fix test gate
sebmarkbage Oct 18, 2022
0d2f03c
Rename experimental_cache to cache
sebmarkbage Oct 23, 2022
86b36bd
New tests
sebmarkbage Oct 23, 2022
19aedff
Tests
sebmarkbage Oct 23, 2022
60f1b5a
Fix float extra comma
sebmarkbage Oct 23, 2022
ca64fdd
Works in www
sebmarkbage Oct 23, 2022
6b1466a
Expose cache
sebmarkbage Oct 24, 2022
977a4e1
Move getCacheForType under enableLegacyCache flag
sebmarkbage Oct 24, 2022
b9cbd3b
Fix shared subset
sebmarkbage Oct 24, 2022
47d2f15
Expose unstable_useCacheRefresh but without seeded argument
sebmarkbage Oct 24, 2022
e6efa83
Mark react-server-dom-webpack to use the version number lined up with…
sebmarkbage Oct 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Enable use, Float, ServerContext, Host Singleton flags
  • Loading branch information
@sebmarkbage
sebmarkbage committed Oct 23, 2022
commit ede1487c45470148d7838022d75efe87b6f6324c
8 changes: 4 additions & 4 deletions packages/shared/ReactFeatureFlags.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,9 +101,9 @@ export const enableSuspenseAvoidThisFallbackFizz = false;

export const enableCPUSuspense = __EXPERIMENTAL__;

export const enableHostSingletons = __EXPERIMENTAL__;
export const enableHostSingletons = true;

export const enableFloat = __EXPERIMENTAL__;
export const enableFloat = true;

// When a node is unmounted, recurse into the Fiber subtree and clean out
// references. Each level cleans up more fiber fields than the previous level.
Expand All @@ -118,7 +118,7 @@ export const enableFloat = __EXPERIMENTAL__;
// aggressiveness.
export const deletedTreeCleanUpLevel = 3;

export const enableUseHook = __EXPERIMENTAL__;
export const enableUseHook = true;

// Enables unstable_useMemoCache hook, intended as a compilation target for
// auto-memoization.
Expand Down Expand Up @@ -253,7 +253,7 @@ export const enableUpdaterTracking = __PROFILE__;

// Only enabled in RN, related to enableComponentStackLocations
export const disableNativeComponentFrames = false;
export const enableServerContext = __EXPERIMENTAL__;
export const enableServerContext = true;

// Internal only.
export const enableGetInspectorDataForInstanceInProduction = false;
Expand Down
8 changes: 4 additions & 4 deletions packages/shared/forks/ReactFeatureFlags.native-fb.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ export const warnAboutSpreadingKeyToJSX = false;
export const enableSuspenseAvoidThisFallback = false;
export const enableSuspenseAvoidThisFallbackFizz = false;
export const enableCPUSuspense = true;
export const enableUseHook = false;
export const enableUseHook = true;
export const enableUseMemoCacheHook = true;
export const enableUseEventHook = false;
export const enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay = true;
Expand All @@ -76,14 +76,14 @@ export const allowConcurrentByDefault = true;
export const enableCustomElementPropertySupport = false;

export const consoleManagedByDevToolsDuringStrictMode = false;
export const enableServerContext = false;
export const enableServerContext = true;

export const enableUseMutableSource = true;

export const enableTransitionTracing = false;

export const enableFloat = false;
export const enableHostSingletons = false;
export const enableFloat = true;
export const enableHostSingletons = true;

export const useModernStrictMode = false;
export const enableFizzExternalRuntime = false;
Expand Down
8 changes: 4 additions & 4 deletions packages/shared/forks/ReactFeatureFlags.native-oss.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export const warnAboutSpreadingKeyToJSX = false;
export const enableSuspenseAvoidThisFallback = false;
export const enableSuspenseAvoidThisFallbackFizz = false;
export const enableCPUSuspense = false;
export const enableUseHook = false;
export const enableUseHook = true;
export const enableUseMemoCacheHook = false;
export const enableUseEventHook = false;
export const enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay = true;
Expand All @@ -67,13 +67,13 @@ export const allowConcurrentByDefault = false;
export const enableCustomElementPropertySupport = false;

export const consoleManagedByDevToolsDuringStrictMode = false;
export const enableServerContext = false;
export const enableServerContext = true;
export const enableUseMutableSource = false;

export const enableTransitionTracing = false;

export const enableFloat = false;
export const enableHostSingletons = false;
export const enableFloat = true;
export const enableHostSingletons = true;

export const useModernStrictMode = false;
export const enableFizzExternalRuntime = false;
Expand Down
8 changes: 4 additions & 4 deletions packages/shared/forks/ReactFeatureFlags.test-renderer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export const warnAboutSpreadingKeyToJSX = false;
export const enableSuspenseAvoidThisFallback = false;
export const enableSuspenseAvoidThisFallbackFizz = false;
export const enableCPUSuspense = false;
export const enableUseHook = false;
export const enableUseHook = true;
export const enableUseMemoCacheHook = false;
export const enableUseEventHook = false;
export const enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay = true;
Expand All @@ -67,13 +67,13 @@ export const allowConcurrentByDefault = false;
export const enableCustomElementPropertySupport = false;

export const consoleManagedByDevToolsDuringStrictMode = false;
export const enableServerContext = false;
export const enableServerContext = true;
export const enableUseMutableSource = false;

export const enableTransitionTracing = false;

export const enableFloat = false;
export const enableHostSingletons = false;
export const enableFloat = true;
export const enableHostSingletons = true;

export const useModernStrictMode = false;
export const enableFizzExternalRuntime = false;
Expand Down
8 changes: 4 additions & 4 deletions packages/shared/forks/ReactFeatureFlags.test-renderer.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ export const deferRenderPhaseUpdateToNextBatch = false;
export const enableSuspenseAvoidThisFallback = false;
export const enableSuspenseAvoidThisFallbackFizz = false;
export const enableCPUSuspense = false;
export const enableUseHook = false;
export const enableUseHook = true;
export const enableUseMemoCacheHook = false;
export const enableUseEventHook = false;
export const enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay = true;
Expand All @@ -65,13 +65,13 @@ export const enableSyncDefaultUpdates = true;
export const allowConcurrentByDefault = true;

export const consoleManagedByDevToolsDuringStrictMode = false;
export const enableServerContext = false;
export const enableServerContext = true;
export const enableUseMutableSource = false;

export const enableTransitionTracing = false;

export const enableFloat = false;
export const enableHostSingletons = false;
export const enableFloat = true;
export const enableHostSingletons = true;

export const useModernStrictMode = false;

Expand Down
8 changes: 4 additions & 4 deletions packages/shared/forks/ReactFeatureFlags.test-renderer.www.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export const warnAboutSpreadingKeyToJSX = false;
export const enableSuspenseAvoidThisFallback = true;
export const enableSuspenseAvoidThisFallbackFizz = false;
export const enableCPUSuspense = false;
export const enableUseHook = false;
export const enableUseHook = true;
export const enableUseMemoCacheHook = false;
export const enableUseEventHook = false;
export const enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay = true;
Expand All @@ -67,15 +67,15 @@ export const allowConcurrentByDefault = true;
export const enableCustomElementPropertySupport = false;

export const consoleManagedByDevToolsDuringStrictMode = false;
export const enableServerContext = false;
export const enableServerContext = true;

// Some www surfaces are still using this. Remove once they have been migrated.
export const enableUseMutableSource = true;

export const enableTransitionTracing = false;

export const enableFloat = false;
export const enableHostSingletons = false;
export const enableFloat = true;
export const enableHostSingletons = true;

export const useModernStrictMode = false;
export const enableFizzExternalRuntime = false;
Expand Down
8 changes: 4 additions & 4 deletions packages/shared/forks/ReactFeatureFlags.testing.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export const warnAboutSpreadingKeyToJSX = false;
export const enableSuspenseAvoidThisFallback = false;
export const enableSuspenseAvoidThisFallbackFizz = false;
export const enableCPUSuspense = false;
export const enableUseHook = false;
export const enableUseHook = true;
export const enableUseMemoCacheHook = false;
export const enableUseEventHook = false;
export const enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay = true;
Expand All @@ -67,13 +67,13 @@ export const allowConcurrentByDefault = false;
export const enableCustomElementPropertySupport = false;

export const consoleManagedByDevToolsDuringStrictMode = false;
export const enableServerContext = false;
export const enableServerContext = true;
export const enableUseMutableSource = false;

export const enableTransitionTracing = false;

export const enableFloat = false;
export const enableHostSingletons = false;
export const enableFloat = true;
export const enableHostSingletons = true;

export const useModernStrictMode = false;
export const enableFizzExternalRuntime = false;
Expand Down
8 changes: 4 additions & 4 deletions packages/shared/forks/ReactFeatureFlags.testing.www.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export const warnAboutSpreadingKeyToJSX = false;
export const enableSuspenseAvoidThisFallback = true;
export const enableSuspenseAvoidThisFallbackFizz = false;
export const enableCPUSuspense = true;
export const enableUseHook = false;
export const enableUseHook = true;
export const enableUseMemoCacheHook = false;
export const enableUseEventHook = false;
export const enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay = true;
Expand All @@ -67,14 +67,14 @@ export const allowConcurrentByDefault = true;
export const enableCustomElementPropertySupport = false;

export const consoleManagedByDevToolsDuringStrictMode = false;
export const enableServerContext = false;
export const enableServerContext = true;
// Some www surfaces are still using this. Remove once they have been migrated.
export const enableUseMutableSource = true;

export const enableTransitionTracing = false;

export const enableFloat = false;
export const enableHostSingletons = false;
export const enableFloat = true;
export const enableHostSingletons = true;

export const useModernStrictMode = false;
export const enableFizzExternalRuntime = false;
Expand Down
4 changes: 2 additions & 2 deletions packages/shared/forks/ReactFeatureFlags.www.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,11 @@ export const enableUpdaterTracking = __PROFILE__;
export const enableSuspenseAvoidThisFallback = true;
export const enableSuspenseAvoidThisFallbackFizz = false;
export const enableCPUSuspense = true;
export const enableFloat = false;
export const enableFloat = true;
export const enableUseHook = true;
export const enableUseMemoCacheHook = true;
export const enableUseEventHook = true;
export const enableHostSingletons = false;
export const enableHostSingletons = true;

// Logs additional User Timing API marks for use with an experimental profiling tool.
export const enableSchedulingProfiler: boolean =
Expand Down