Skip to content

Do not unmount layout effects if ancestor Offscreen is hidden #25628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 4, 2022
Merged

Do not unmount layout effects if ancestor Offscreen is hidden #25628

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3acc8db
Do not unmount layout effects if ancestor Offscreen is hidden
sammy-SC Nov 3, 2022
3d25d1b
Rename variable
sammy-SC Nov 3, 2022
eebfd29
yarn replace-fork
sammy-SC Nov 3, 2022
0a9d7c1
prettier
sammy-SC Nov 3, 2022
876b486
Correct comment
sammy-SC Nov 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
prettier
  • Loading branch information
@sammy-SC
sammy-SC committed Nov 3, 2022
commit 0a9d7c1db8c9b13f5641ebb5241d7624ebc8fba7
2 changes: 1 addition & 1 deletion packages/react-reconciler/src/__tests__/ReactOffscreen-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ describe('ReactOffscreen', () => {
}

let _setIsVisible;
let isFirstRender = true
let isFirstRender = true;

function App() {
const [isVisible, setIsVisible] = React.useState(true);
Expand Down