Skip to content

[Fizz][Float] emit viewport meta before preloads #27201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gnoff merged 1 commit into from
Aug 7, 2023
Merged

[Fizz][Float] emit viewport meta before preloads #27201

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
the viewport meta tag needs to be emitted before any preloads to have… 
… the proper resolution loaded in some cases. This change updates our queueing strategy to utilize our preconnect queue for the viewport meta tag
  • Loading branch information
@gnoff
gnoff committed Aug 7, 2023
commit bc15396ab1ea14181f7398b3e2ff0c572e7680b8
3 changes: 3 additions & 0 deletions packages/react-dom-bindings/src/server/ReactFizzConfigDOM.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1920,6 +1920,9 @@ function pushMeta(

if (typeof props.charSet === 'string') {
return pushSelfClosing(responseState.charsetChunks, props, 'meta');
} else if (props.name === 'viewport') {
// "viewport" isn't related to preconnect but it has the right priority
return pushSelfClosing(responseState.preconnectChunks, props, 'meta');
} else {
return pushSelfClosing(responseState.hoistableChunks, props, 'meta');
}
Expand Down