Skip to content

[RSC @ Meta] Simplify implementation of isClientReference, getClientReferenceKey, resolveClientReferenceMetadata #27839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 19, 2023
Merged

[RSC @ Meta] Simplify implementation of isClientReference, getClientReferenceKey, resolveClientReferenceMetadata #27839

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6c82eff
[rsc @fb ] simplify implementation of isClientReference and friends
alunyov Dec 15, 2023
ae93fcb
flow fix
alunyov Dec 15, 2023
201dc0c
lint
alunyov Dec 15, 2023
95a8c4f
minor change
alunyov Dec 15, 2023
625e177
pass isClientReference via config
alunyov Dec 15, 2023
5f125f9
keep registerClientReference and registerServerReference
alunyov Dec 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
keep registerClientReference and registerServerReference
  • Loading branch information
@alunyov
alunyov committed Dec 16, 2023
commit 5f125f9e132142fc84cc386bdf67e204b11ca377
2 changes: 2 additions & 0 deletions packages/react-server-dom-fb/src/ReactFlightDOMServerFB.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ import {
import {setByteLengthOfChunkImplementation} from 'react-server/src/ReactServerStreamConfig';

export {
registerClientReference,
registerServerReference,
getRequestedClientReferencesKeys,
clearRequestedClientReferencesKeysSet,
setCheckIsClientReference,
Expand Down
12 changes: 12 additions & 0 deletions packages/react-server-dom-fb/src/ReactFlightReferencesFB.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@ export function setCheckIsClientReference(
checkIsClientReference = impl;
}

export function registerClientReference<T>(
clientReference: ClientReference<T>,
): void {}

export function isClientReference(reference: mixed): boolean {
if (checkIsClientReference == null) {
throw new Error('Expected implementation for checkIsClientReference.');
Expand All @@ -58,6 +62,14 @@ export function resolveClientReferenceMetadata<T>(
return {moduleId: clientReference.getModuleId(), exportName: 'default'};
}

export function registerServerReference<T>(
serverReference: ServerReference<T>,
id: string,
exportName: null | string,
): ServerReference<T> {
throw new Error('registerServerReference: Not Implemented.');
}

export function isServerReference<T>(reference: T): boolean {
throw new Error('isServerReference: Not Implemented.');
}
Expand Down