Skip to content

Add smoke test for flight fixture #28350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 21, 2024
Merged

Add smoke test for flight fixture #28350

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e110488
Add smoke test to flight fixture
eps1lon Feb 15, 2024
561495b
Debug webserver in CI
eps1lon Feb 15, 2024
be08cc5
Fix CI value
eps1lon Feb 15, 2024
9aa8c4e
Better webserver debugging
Feb 16, 2024
3a94495
Ensure dependency constraints are fulfilled
Feb 16, 2024
99466f8
yarn build is required
Feb 16, 2024
bdbbce8
Add hint for require Node.js version
Feb 16, 2024
0320dd3
Ensure correct Node.js version is used
Feb 16, 2024
76fc01c
Ensure build completed
Feb 16, 2024
0bf35c3
Fix build
Feb 16, 2024
0a7acc5
Fix bundle error
Feb 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix bundle error
  • Loading branch information
Sebastian Silbermann committed Feb 21, 2024
commit 0a7acc5072cea13741a19a03ef0b9b1df6113c3d
7 changes: 0 additions & 7 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,13 +271,6 @@ jobs:
command: |
npx playwright install
sudo npx playwright install-deps
- run:
working_directory: fixtures/flight
name: yarn build
command: |
yarn build
# Need to build twice for unknown reasons
yarn build
- run:
name: Run tests
working_directory: fixtures/flight
Expand Down
2 changes: 1 addition & 1 deletion fixtures/flight/playwright.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export default defineConfig({
},
],
webServer: {
command: 'yarn dev',
command: 'FAST_REFRESH=false yarn dev',
url: 'http://localhost:3000',
reuseExistingServer: !isCI,
},
Expand Down