Skip to content

[Flight] Instrument the Console in the RSC Environment and Replay Logs on the Client #28384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 21, 2024
Merged

[Flight] Instrument the Console in the RSC Environment and Replay Logs on the Client #28384

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
970b241
Disable log tear down check in tests
sebmarkbage Feb 19, 2024
33e1cbf
Add flag
sebmarkbage Feb 19, 2024
4d8861e
Instrument console in a Flight server environment and replay them on …
sebmarkbage Feb 19, 2024
a5f5528
Pass stack trace as part as part of the console entry
sebmarkbage Feb 19, 2024
2fe5fb0
Serialize console arguments using a special model serializer
sebmarkbage Feb 20, 2024
609cb19
Don't replay consoles written inside onError/onPostpone.
sebmarkbage Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Disable log tear down check in tests
  • Loading branch information
@sebmarkbage
sebmarkbage committed Feb 20, 2024
commit 970b2414a24c8cab859a583d1ac9bdfc35f65f98
6 changes: 3 additions & 3 deletions scripts/jest/setupTests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,9 @@ if (process.env.REACT_CLASS_EQUIVALENCE_TEST) {
console[methodName] !== mockMethod &&
!jest.isMockFunction(console[methodName])
) {
throw new Error(
`Test did not tear down console.${methodName} mock properly.`
);
// throw new Error(
// `Test did not tear down console.${methodName} mock properly.`
// );
Comment on lines +99 to +101
Copy link
Collaborator

@gnoff gnoff Feb 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you mean to deactivate this permanently?

Copy link
Collaborator Author

@sebmarkbage sebmarkbage Feb 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Although I'm not sure the best strategy to go forward with here. Ideally we'd delete it but maybe there's some way to restore it? I guess I'll leave it commented out for now.

}
if (unexpectedConsoleCallStacks.length > 0) {
const messages = unexpectedConsoleCallStacks.map(
Expand Down