Skip to content

[Fizz] Support basic SuspenseList forwards/backwards revealOrder #33306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 19, 2025
+792 −31
Merged

[Fizz] Support basic SuspenseList forwards/backwards revealOrder #33306

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c97a6d5
Test
sebmarkbage May 18, 2025
8aac798
Track the row that we're rendering into as a context on the task
sebmarkbage May 17, 2025
95ebd58
Track SuspenseListRow per row rendered
sebmarkbage May 19, 2025
e74fb07
Block rows from completing when there's still incomplete tasks within…
sebmarkbage May 19, 2025
7e8aec6
Block a row from completing until a Suspense boundary completes
sebmarkbage May 19, 2025
8ab5e1f
Use in fixture
sebmarkbage May 19, 2025
662f9b5
Fix test that's now works properly
sebmarkbage May 19, 2025
0c7f03f
Update packages/react-server/src/ReactFizzServer.js
sebmarkbage May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update packages/react-server/src/ReactFizzServer.js 
Typo

Co-authored-by: Sebastian "Sebbie" Silbermann <[email protected]>
  • Loading branch information
@sebmarkbage @eps1lon
sebmarkbage and eps1lon authored May 19, 2025
commit 0c7f03f02a51b20b23ee6a89a105f6b989905044
2 changes: 1 addition & 1 deletion packages/react-server/src/ReactFizzServer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1670,7 +1670,7 @@ function replaySuspenseBoundary(

function finishSuspenseListRow(request: Request, row: SuspenseListRow): void {
// This row finished. Now we have to unblock all the next rows that were blocked on this.
// We do this in a loop to avoid stash overflow for very long lists that get unblocked.
// We do this in a loop to avoid stack overflow for very long lists that get unblocked.
let unblockedRow = row.next;
while (unblockedRow !== null) {
// Unblocking the boundaries will decrement the count of this row but we keep it above
Expand Down
Loading