Skip to content

[Fiber] disableNewFiberFeatures bugfix: host component children arrays #8797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
acdlite merged 6 commits into from
Jan 25, 2017
Merged

[Fiber] disableNewFiberFeatures bugfix: host component children arrays #8797

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
16956ed
disableNewFiberFeatures bugfix: host component children arrays
acdlite Jan 15, 2017
1ac6be2
Add test for iterables, too
acdlite Jan 17, 2017
5c4362d
Remove outdated TODO
acdlite Jan 17, 2017
c0e5df6
Make disableNewFiberFeatures = true the default when runnings tests
acdlite Jan 17, 2017
645ad6d
Add test for mocked render functions
acdlite Jan 17, 2017
ba1d382
Use multiple checks instead of forking the entire function
acdlite Jan 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove outdated TODO
  • Loading branch information
@acdlite
acdlite committed Jan 25, 2017
commit 5c4362dc5c30357aed829e630ca4a03bd812e482
3 changes: 0 additions & 3 deletions src/renderers/dom/fiber/__tests__/ReactDOMFiber-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1098,9 +1098,6 @@ describe('ReactDOMFiber', () => {
});

it('throws if non-element passed to top-level render', () => {
// FIXME: These assertions pass individually, but they leave React in
// an inconsistent state. This suggests an error-handling bug. I'll fix
// this in a separate PR.
const message = 'render(): Invalid component element.';
expect(() => ReactDOM.render(null, container)).toThrow(message, container);
expect(() => ReactDOM.render(undefined, container)).toThrow(message, container);
Expand Down