Skip to content

[Fiber] Mount/unmount warnings and invariants #8919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
acdlite merged 7 commits into from
Feb 7, 2017
+110 −24
Merged

[Fiber] Mount/unmount warnings and invariants #8919

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
822587e
Add extra invalid element info to invariant message
acdlite Feb 2, 2017
d47c215
Warn when mounting into document.body
acdlite Feb 2, 2017
f482329
Warn when rendering into React-rendered child that isn't a root
acdlite Feb 2, 2017
87bc7ce
Warn if unmounting a tree that was rendered by a different copy of React
acdlite Feb 2, 2017
255e5ae
Rendering into an empty React-rendered element should not warn
acdlite Feb 6, 2017
9fcf761
Run test script
acdlite Feb 6, 2017
0564b08
Split into multiple invariants
acdlite Feb 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Warn when rendering into React-rendered child that isn't a root
  • Loading branch information
@acdlite
acdlite committed Feb 2, 2017
commit f4823295af9792c2ef6e0e7da6a4628009dd227d
9 changes: 9 additions & 0 deletions src/renderers/dom/fiber/ReactDOMFiber.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,6 +386,15 @@ var ReactDOM = {
}

if (__DEV__) {
warning(
!ReactDOMComponentTree.getInstanceFromNode(container) ||
container._reactRootContainer,
'render(...): Replacing React-rendered children with a new root ' +
'component. If you intended to update the children of this node, ' +
'you should instead have the existing children update their state ' +
'and render the new components instead of calling ReactDOM.render.'
);

warning(
!container.tagName || container.tagName.toUpperCase() !== 'BODY',
'render(): Rendering components directly into document.body is ' +
Expand Down