Skip to content

Improve unmapper file heuristic, add limited warning support, and ignore internal errors #2128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
May 13, 2017
Merged

Improve unmapper file heuristic, add limited warning support, and ignore internal errors #2128

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
afba3fc
Browser sort is not stable
Timer May 11, 2017
47cd783
Fix ordering of final message
Timer May 11, 2017
cf897f0
Register the warning capture
Timer May 11, 2017
a150609
Display only createElement warnings
Timer May 11, 2017
8dfb007
Use different method name
Timer May 11, 2017
4bae90d
Fix regression
Timer May 11, 2017
ab81262
Ignore errors with only node_module files
Timer May 11, 2017
79af0fc
Ignore null files, too
Timer May 11, 2017
ec12b8c
Revise count
Timer May 12, 2017
fb7411b
Revise warning
Timer May 12, 2017
cd9c43f
Update overlay.js
Timer May 12, 2017
83e6324
Add support for https://github.com/facebook/react/pull/9679
Timer May 13, 2017
ede4f9b
Use absolute paths
Timer May 13, 2017
8997f58
Trim path if it's absolute
Timer May 13, 2017
19eadc2
Make sure it's an absolute path
Timer May 13, 2017
43a97e3
Oops
Timer May 13, 2017
52a39a4
Tweak for new behavior
gaearon May 13, 2017
4d9f647
Make it safer
gaearon May 13, 2017
d7f81e7
More resilient warnings
gaearon May 13, 2017
2d4fdad
Merge branch 'master' into unmapper-fix
gaearon May 13, 2017
4cb6be3
Prettier output
gaearon May 13, 2017
11fc0f0
Merge remote-tracking branch 'Timer/unmapper-fix' into Timer-unmapper…
gaearon May 13, 2017
9da83b3
Fix flow
gaearon May 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Prettier output
  • Loading branch information
@gaearon
gaearon committed May 13, 2017
commit 4cb6be38572d4250f9498c4a1d156eb5875a4c15
7 changes: 5 additions & 2 deletions packages/react-error-overlay/src/components/overlay.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,13 @@ function createOverlay(
finalMessage = finalMessage
// TODO: maybe remove this prefix from fbjs?
// It's just scaring people
.replace('Invariant Violation: ', '')
.replace(/^Invariant Violation:\s*/, '')
// This is not helpful either:
.replace(/^Warning:\s*/, '')
// Break the actionable part to the next line.
// AFAIK React 16+ should already do this.
.replace(' Check the render method', '\n\nCheck the render method');
.replace(' Check the render method', '\n\nCheck the render method')
.replace(' Check your code at', '\n\nCheck your code at');

// Put it in the DOM
header.appendChild(document.createTextNode(finalMessage));
Expand Down
4 changes: 1 addition & 3 deletions packages/react-error-overlay/src/utils/warnings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,8 @@ function massage(
frames: ReactFrame[]
): { message: string, stack: string } {
let message = stripInlineStacktrace(warning);
if (message.indexOf('Warning: ') === 0) {
message = message.substring('Warning: '.length);
}

// Reassemble the stack with full filenames provided by React
let stack = '';
for (let index = 0; index < frames.length; ++index) {
const { fileName, lineNumber } = frames[index];
Expand Down