[fix] setUA(): remove trailing space from user-agent string

Author: faisalman

src/main/ua-parser.js

@@ -206,10 +206,8 @@
             return strip(/\\?\"/g, str); 
         },
         trim = function (str, len) {
-            if (isString(str)) {
-                str = strip(/^\s\s*/, str);
-                return typeof len === TYPEOF.UNDEFINED ? str : str.substring(0, UA_MAX_LENGTH);
-            }
+            str = strip(/^\s\s*/, String(str));
+            return typeof len === TYPEOF.UNDEFINED ? str : str.substring(0, len);
     };
 
     ///////////////
@@ -1464,8 +1462,7 @@
             ['getResult', createItemFunc(RESULT)],
             ['getUA', function () { return userAgent; }],
             ['setUA', function (ua) {
-                if (isString(ua))
-                    userAgent = ua.length > UA_MAX_LENGTH ? trim(ua, UA_MAX_LENGTH) : ua;
+                if (isString(ua)) userAgent = trim(ua, UA_MAX_LENGTH);
                 return this;
             }]
         ])

test/unit/main.js

@@ -163,6 +163,14 @@ describe('Extending Regex', function () {
     assert.deepEqual(myParser3.setUA(myUA2).getDevice(), {vendor: "MyTab", model: "14 Pro Max", type: "tablet"});
 });
 
+describe('User-agent with trailing space', function () {
+    it ('trailing space will be trimmed', function () {
+        const uastring = '     Opera/9.21 (Windows NT 5.1; U; ru)     ';
+        const { ua } = UAParser(uastring);
+        assert.equal(ua, 'Opera/9.21 (Windows NT 5.1; U; ru)     ');
+    });
+});
+
 describe('User-agent length', function () {
     var UA_MAX_LENGTH = 500;