Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
removed postgres_password from alembic.ini, read it from env var instead
  • Loading branch information
ebreton committed Apr 12, 2019
commit 7abb977dfe6edc6c18b1dbb05b3f53c6c57c78f5
3 changes: 0 additions & 3 deletions {{cookiecutter.project_slug}}/backend/app/alembic.ini
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,6 @@ script_location = alembic
# are written from script.py.mako
# output_encoding = utf-8

sqlalchemy.url = postgresql://postgres:{{cookiecutter.postgres_password}}@db/app


# Logging configuration
[loggers]
keys = root,sqlalchemy,alembic
Expand Down
18 changes: 16 additions & 2 deletions {{cookiecutter.project_slug}}/backend/app/alembic/env.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
from __future__ import with_statement

import os

from alembic import context
from sqlalchemy import engine_from_config, pool
from logging.config import fileConfig
Expand Down Expand Up @@ -27,6 +30,15 @@
# ... etc.


def get_url():
return "postgresql://%s:%s@%s/%s" % (
os.getenv("POSTGRES_USER", "postgres"),
os.getenv("POSTGRES_PASSWORD", ""),
os.getenv("POSTGRES_SERVER", "db"),
os.getenv("POSTGRES_DB", "app"),
)


def run_migrations_offline():
"""Run migrations in 'offline' mode.

Expand All @@ -39,7 +51,7 @@ def run_migrations_offline():
script output.

"""
url = config.get_main_option("sqlalchemy.url")
url = get_url()
context.configure(
url=url, target_metadata=target_metadata, literal_binds=True, compare_type=True
)
Expand All @@ -55,8 +67,10 @@ def run_migrations_online():
and associate a connection with the context.

"""
configuration = config.get_section(config.config_ini_section)
configuration['sqlalchemy.url'] = get_url()
connectable = engine_from_config(
config.get_section(config.config_ini_section),
configuration,
prefix="sqlalchemy.",
poolclass=pool.NullPool,
)
Expand Down