Skip to content

Conversation

@lahirumaramba
Copy link
Member

@lahirumaramba lahirumaramba commented Nov 4, 2022

If FIREBASE_AUTH_EMULATOR_HOST env var is set the SDK shouldn't connect to Auth servers for OAuth2 handshake. This PR sets the emulator credentials when emulator mode is set.

b/220373445

RELEASE NOTE: Fixed an issue in the Auth API to correctly set the emulator credentials when the FIREBASE_AUTH_EMULATOR_HOST environment variable is set to point to the emulator Auth endpoint.

@lahirumaramba lahirumaramba added release-note release:stage Stage a release candidate labels Nov 4, 2022
@lahirumaramba lahirumaramba force-pushed the lm-fix-auth-emu branch 3 times, most recently from 8c125b2 to f1a1d7d Compare November 4, 2022 21:28
@lahirumaramba
Copy link
Member Author

lahirumaramba commented Nov 4, 2022

This change could break Firestore if the FIREBASE_AUTH_EMULATOR_HOST is set... changing to draft until I take a closer look. That was a different regression now fixed in #735 . This PR is good to go.

@lahirumaramba lahirumaramba marked this pull request as ready for review November 7, 2022 19:54
Copy link

@kroikie kroikie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lahirumaramba lahirumaramba merged commit 9f15838 into master Nov 8, 2022
@lahirumaramba lahirumaramba deleted the lm-fix-auth-emu branch November 8, 2022 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release:stage Stage a release candidate release-note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants